Unclear error message in case of network addresses intersection

[Julia Aranovich]

Steps to reproduce in Fuel UI:

1) create default env
2) go to Networks tab and create a new node network group
3) click Save Changes button

Actual result: there is an error message when trying to save the network settings:

Address space intersection between networks:
management, management
Address space intersection between networks:
storage, storage

I think the message should specify a node network group name(id?) for the intersected networks. If you have 3 or more node network groups, there will be totally unclear, storage networks in which node network groups are intersected?

[Bug Checker Bot (bug-checker)]

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

expected result

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

[Dmitry Pyzhov (dpyzhov)]

Pavlo, please assign bug to yourself if you are working on it.

[Pavlo Sumkin (ymkins)]

Cannot reproduce on the fuel-9.0-124.
Seems like fixed in https://github.com/openstack/fuel-ui/commit/58c2ccc
--
Fix complexity warning for network validation

mplements: blueprint converge-to-eslint-config-openstack

Change-Id: Id3259f1c9d187d556a05a5c37b00b204482ba443

[Alexandr Kostrikov (akostrikov-mirantis)]

Current message with id:

Address space intersection between networks:
management, public (Network IDs: 11, 14)
Address space intersection between networks:
public, management (Network IDs: 14, 15)
Cancel ChangesSave Settings

I propose to make more clear format like that:
Address space intersection between networks:
11[management@default], 14[public@another_net_group]

[Grigory Mikhailov (gmikhailov)]

Verified on #fuel-9.0-mos-490 iso.
Unclear error message in case of network addresses intersection is not observed.

[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id: 490
cat /etc/fuel_build_number: 490
cat /etc/fuel_release: 9.0
cat /etc/fuel_openstack_version: mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6349.noarch
 fuel-misc-9.0.0-1.mos8460.noarch
 python-packetary-9.0.0-1.mos140.noarch
 fuel-bootstrap-cli-9.0.0-1.mos285.noarch
 fuel-migrate-9.0.0-1.mos8460.noarch
 rubygem-astute-9.0.0-1.mos750.noarch
 fuel-mirror-9.0.0-1.mos140.noarch
 shotgun-9.0.0-1.mos90.noarch
 fuel-openstack-metadata-9.0.0-1.mos8743.noarch
 fuel-notify-9.0.0-1.mos8460.noarch
 nailgun-mcagents-9.0.0-1.mos750.noarch
 python-fuelclient-9.0.0-1.mos325.noarch
 fuel-9.0.0-1.mos6349.noarch
 fuel-utils-9.0.0-1.mos8460.noarch
 fuel-setup-9.0.0-1.mos6349.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8743.noarch
 fuel-library9.0-9.0.0-1.mos8460.noarch
 network-checker-9.0.0-1.mos74.x86_64
 fuel-agent-9.0.0-1.mos285.noarch
 fuel-ui-9.0.0-1.mos2717.noarch
 fuel-ostf-9.0.0-1.mos936.noarch
 fuelmenu-9.0.0-1.mos274.noarch
 fuel-nailgun-9.0.0-1.mos8743.noarch