OCF: Use private attributes to not trigger pacemaker transitions on each update

[Bogdan Dobrelya]

According to Andrew's comments https://review.openstack.org/#/c/248319 crm_attribute does not support private attributes for corosync nodes. Each update with crm_attribute triggers unnecessary transitions. We should use private attributes for nodes when possible.

That means that "crm_attribute -N <node>" should be replaced to private attributes with "attrd_updater", see examples
https://review.openstack.org/#/c/248319/1/ocf/NovaEvacuate
https://review.openstack.org/#/c/248627/1/ocf/NovaEvacuate

Note, for some cases other nodes should be able to see attributes of each other. For such cases, private attributes should not be used.

[Bogdan Dobrelya (bogdando)]

I'm not sure of the impact of this issue. Is it so bad to have extra transitions? Maybe not, but still it'd be better not having them for sure. That is why I put the medium prio

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/281202

[Liubov Efremova (lefremova)]

I marked the previous fix as 'Partial-Bug: #1524672', but after further investigations I suppose it closes the current issue.

Node attributes are also created in 'fuel-library/files/fuel-ha-utils/ocf/mysql-wss' but we shouldn't change them to private:
        -'galera_master_timeout' is a cluster option
        -'gtid' should be public as we are getting its value in 'get_possible_masters()' method for all online nodes in cluster.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/281202
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=9a3aa4b709138e25d1f0233c1d5ee22644924b21
Submitter: Jenkins
Branch: master

commit 9a3aa4b709138e25d1f0233c1d5ee22644924b21
Author: Liubov Efremova <email address hidden>
Date: Wed Feb 17 13:38:02 2016 +0300

    Private attributes usage in rabbitmq script

    There are three types of rabbitmq attributes for pacemaker nodes:
     -'rabbit-master'
     -'rabbit-start-time'
     - timeouts:
      -'rabbit_list_channels_timeouts'
      -'rabbit_get_alarms_timeouts'
      -'rabbit_list_queues_timeouts'

    Attributes with names 'rabbit-master' and 'rabbit-start-time' should be
    public because we monitor this attributes in cycle for all nodes in our
    script.

    All timeouts attributes were changed to private to avoid unnecessary
    transitions.

    Also, --lifetime and --node options were removed for attrd_updater as
    'lifetime' for this command is always 'reboot' and 'node' default value
    is local one.

    Closes-bug: #1524672
    Change-Id: Ie45ae3a82b8daa35dbdd977dc894877160af457b

[Bogdan Dobrelya (bogdando)]

Revert https://review.openstack.org/#/c/291739

[Liubov Efremova (lefremova)]

The current version of Pacemaker is 1.1.12. The command 'attrd_updater' have '-p' option only since 1.1.13. It's necessary to update the version of Pacemaker at first and then apply the previous commit again.

[Bug Checker Bot (bug-checker)]

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

version

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

[Matthew Mosesohn (raytrac3r)]

MOS Linux team, please investigate the effort required to raise the version of pacemaker to add this capability. It will reduce the amount of transitions in Corosync.

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: master
Change author: Ivan Suzdal <email address hidden>
Review: https://review.fuel-infra.org/19059

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/19059
Submitter: Pkgs Jenkins <email address hidden>
Branch: master

Commit: 41b68cf5f13e511373eb1a102345b0119fc198ae
Author: Ivan Suzdal <email address hidden>
Date: Fri Apr 1 14:29:37 2016

Bump pacemaker version to 1.1.14

Backport from xenial

Change-Id: Ia260241505d2cb32f64f293e7072e6931e78a523
Closes-Bug: #1524672

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: 9.0
Change author: Ivan Suzdal <email address hidden>
Review: https://review.fuel-infra.org/19178

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/19178
Submitter: Pkgs Jenkins <email address hidden>
Branch: 9.0

Commit: a4705a31308855d23b62d33dad21ff28b8c34adf
Author: Ivan Suzdal <email address hidden>
Date: Tue Apr 5 10:28:55 2016

Bump pacemaker version to 1.1.14

Backport from xenial

Change-Id: Ia260241505d2cb32f64f293e7072e6931e78a523
Closes-Bug: #1524672
(cherry picked from commit 41b68cf5f13e511373eb1a102345b0119fc198ae)

[Alexey Lebedeff (alebedev-a)]

'crmsh' package is broken after this upgrade - pacemaker 1.1.14 compatibilty was added only in crmsh 2.1.5

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/19739
Submitter: Pkgs Jenkins <email address hidden>
Branch: master

Commit: 6e68a7c7bdf0f52cfef29e79108d06b9f037e7e3
Author: Ivan Suzdal <email address hidden>
Date: Mon Apr 18 13:55:40 2016

Bump crmsh package to 2.1.5

Rebuilt from upstream tag 2.1.5

Related-Bug: #1524672
Related-Bug: #1567864

Change-Id: Iabe3e5479fa9196bc10346ed762899d8ca82d8f0

[Fuel Devops McRobotson (fuel-devops-robot)]

Related fix proposed to branch: 9.0
Change author: Ivan Suzdal <email address hidden>
Review: https://review.fuel-infra.org/19783

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/19783
Submitter: Pkgs Jenkins <email address hidden>
Branch: 9.0

Commit: 7b51b3cba8d3f204c412242b09d1f20bd9998721
Author: Ivan Suzdal <email address hidden>
Date: Mon Apr 18 18:14:57 2016

Bump crmsh package to 2.1.5

Rebuilt from upstream tag 2.1.5

Related-Bug: #1524672
Closes-Bug: #1567864

Change-Id: Iabe3e5479fa9196bc10346ed762899d8ca82d8f0
(cherry picked from commit 6e68a7c7bdf0f52cfef29e79108d06b9f037e7e3)

[Alexander Gubanov (ogubanov)]

Verified on MOS 9.0 (build 232):
root@node-1:~# dpkg -l | grep crmsh
ii crmsh 2.1.5-1~u14.04+mos1 amd64 CRM shell for the pacemaker cluster manager

Moved to "Fix Release"

[Bogdan Dobrelya (bogdando)]

Note, updated Pacemaker only enables the real fix to be applied, which is in progress (https://review.openstack.org/#/c/314633/), reopenting

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/314633
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=f7f0f17ffe6d65b7919f982c5a2bfb8f3746e402
Submitter: Jenkins
Branch: master

commit f7f0f17ffe6d65b7919f982c5a2bfb8f3746e402
Author: Liubov Efremova <email address hidden>
Date: Tue May 10 15:27:53 2016 +0000

    Private attributes usage in rabbitmq script

    There are three types of rabbitmq attributes for pacemaker nodes:
     -'rabbit-master'
     -'rabbit-start-time'
     - timeouts:
      -'rabbit_list_channels_timeouts'
      -'rabbit_get_alarms_timeouts'
      -'rabbit_list_queues_timeouts'

    Attributes with names 'rabbit-master' and 'rabbit-start-time' should be
    public because we monitor this attributes in cycle for all nodes in our
    script.

    All timeouts attributes were changed to private to avoid unnecessary
    transitions.

    Also, --lifetime and --node options were removed for attrd_updater as
    'lifetime' for this command is always 'reboot' and 'node' default value
    is local one.

    This reverts commit b2b191d2e28b96c9f9a6ea440a383cf4f691d8ad.
    (As the pacemaker version was updated).

    Closes-bug: #1524672

    Change-Id: I6f0d4a99641b847321754d75605a78fbbc96ddad