Heat needs to configure the list of enabled os-collect-config collectors

[Steve Baker]

When changing the software_config_transport for an existing server, os-collect-config will continue using the data from the old transport which will become increasingly stale and will sometimes mask values from the new transport.

To mitigate this, heat needs to set the os-apply-config data to populate the os-collect-config.conf [DEFAULT] collectors list so that only the appropriate collectors are enabled.

This will also suppress the "WARNING collector not configured" logging which are harmless but freak people out.

[Rico Lin (rico-lin)]

https://review.openstack.org/#/c/257625/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/257625
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=5d1762fec6a7d3f2eaa5f7e4e7ac048e77843cb0
Submitter: Jenkins
Branch: master

commit 5d1762fec6a7d3f2eaa5f7e4e7ac048e77843cb0
Author: Steve Baker <email address hidden>
Date: Tue Dec 15 08:55:00 2015 +1300

    Build list of enabled os-collect-config collectors

    When changing the software_config_transport for an existing server,
    os-collect-config will continue using the data from the old transport
    which will become increasingly stale and will sometimes mask values from
    the new transport.

    The default list of collectors in os-collect-config is:
    heat_local, ec2, cfn, heat, request, local, zaqar

    This change explicitly enables these collectors:
    ec2, <current transport>, local

    ``ec2`` is the nova metadata service, so should always be enabled.

    ``local`` allows local file overrides - this is generally unused but is
    enabled for users who choose to use it for additional config data, or to
    override the heat provided data.

    ``heat_local`` is only used on the first run of an unconfigured
    os-collect-config for bootstrapping its own config file, so it can and
    should be disabled for subsequent polling.

    Change-Id: I9cdb057212c7a4404f6966a55cde9eab5ad86759
    Closes-Bug: #1523676

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/heat 6.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/289097

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/289097
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=55f6324cf79aca151d76f9baa0fbb37cfb1c72fb
Submitter: Jenkins
Branch: stable/liberty

commit 55f6324cf79aca151d76f9baa0fbb37cfb1c72fb
Author: Steve Baker <email address hidden>
Date: Tue Dec 15 08:55:00 2015 +1300

    Build list of enabled os-collect-config collectors

    When changing the software_config_transport for an existing server,
    os-collect-config will continue using the data from the old transport
    which will become increasingly stale and will sometimes mask values from
    the new transport.

    The default list of collectors in os-collect-config is:
    heat_local, ec2, cfn, heat, request, local, zaqar

    This change explicitly enables these collectors:
    ec2, <current transport>, local

    ``ec2`` is the nova metadata service, so should always be enabled.

    ``local`` allows local file overrides - this is generally unused but is
    enabled for users who choose to use it for additional config data, or to
    override the heat provided data.

    ``heat_local`` is only used on the first run of an unconfigured
    os-collect-config for bootstrapping its own config file, so it can and
    should be disabled for subsequent polling.

    Change-Id: I9cdb057212c7a4404f6966a55cde9eab5ad86759
    Closes-Bug: #1523676
    (cherry picked from commit 5d1762fec6a7d3f2eaa5f7e4e7ac048e77843cb0)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 5.0.2 release.