CI test failure (fd leak) in ServerDisconnect.doesnt_stop_client_calling_API_functions

[Alexandros Frantzis]

As seen here: https://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/95/consoleFull

[ RUN ] ServerDisconnect.doesnt_stop_client_calling_API_functions
[1449163763.062465] mirserver: Starting
[1449163763.065706] mirserver: Selected driver: dummy (version 0.18.0)
[1449163763.081446] mirserver: Initial display configuration:
[1449163763.082014] mirserver: 1.1: VGA 0.0" 0x0mm
[1449163763.082135] mirserver: Current mode 1600x1600 60.00Hz
[1449163763.082202] mirserver: Preferred mode 1600x1600 60.00Hz
[1449163763.082262] mirserver: Logical position +0+0
[1449163763.129536] mirserver: Using software cursor
[1449163763.135921] mirserver: Selected input driver: stub-input (version: 0.18.0)
[1449163763.136192] mirserver: Mir version 0.18.0
[1449163763.201426] mirserver: Stopping
==12888== FILE DESCRIPTORS: 5 open at exit.
==12888== Open file descriptor 13: /dev/zero
==12888== at 0x6BA723D: ??? (syscall-template.S:81)
==12888== by 0x5B3BD28: mir::receive_data(mir::Fd const&, void*, unsigned long, std::vector<mir::Fd, std::allocator<mir::Fd> >&) (fd_socket_transmission.cpp:125)
==12888== by 0x54B2231: mir::client::rpc::StreamSocketTransport::receive_data(void*, unsigned long, std::vector<mir::Fd, std::allocator<mir::Fd> >&) (stream_socket_transport.cpp:137)
==12888== by 0x54BBCF7: mir::client::rpc::MirProtobufRpcChannel::process_event_sequence(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (mir_protobuf_rpc_channel.cpp:271)
==12888== by 0x54BC370: mir::client::rpc::MirProtobufRpcChannel::on_data_available() (mir_protobuf_rpc_channel.cpp:380)
==12888== by 0x54B1F86: operator()<std::shared_ptr<mir::client::rpc::StreamTransport::Observer> > (stream_socket_transport.cpp:40)
==12888== by 0x54B1F86: _ZNSt17_Function_handlerIFvRKSt10shared_ptrIN3mir6client3rpc15StreamTransport8ObserverEEEZNS3_18TransportObservers17on_data_availableEvEUlT_E_E9_M_invokeERKSt9_Any_dataS8_ (functional:1871)
==12888== by 0x54B4CEA: operator() (functional:2271)
==12888== by 0x54B4CEA: mir::ThreadSafeList<std::shared_ptr<mir::client::rpc::StreamTransport::Observer> >::for_each(std::function<void (std::shared_ptr<mir::client::rpc::StreamTransport::Observer> const&)> const&) (thread_safe_list.h:80)
==12888== by 0x54B211C: mir::client::rpc::TransportObservers::on_data_available() (stream_socket_transport.cpp:40)
==12888== by 0x54B2346: mir::client::rpc::StreamSocketTransport::dispatch(unsigned int) (stream_socket_transport.cpp:208)
==12888== by 0x5B314B3: mir::dispatch::MultiplexingDispatchable::dispatch(unsigned int) (multiplexing_dispatchable.cpp:210)
==12888== by 0x5B314B3: mir::dispatch::MultiplexingDispatchable::dispatch(unsigned int) (multiplexing_dispatchable.cpp:210)
==12888== by 0x5B33AFE: (anonymous namespace)::dispatch_loop(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::shared_ptr<mir::dispatch::ThreadedDispatcher::ThreadShutdownRequestHandler>, std::shared_ptr<mir::dispatch::Dispatchable>, std::function<void ()> const&) (threaded_dispatcher.cpp:211)
==12888== by 0x5B35CFD: _M_invoke<0ul, 1ul, 2ul, 3ul> (functional:1531)
==12888== by 0x5B35CFD: operator() (functional:1520)
==12888== by 0x5B35CFD: std::thread::_Impl<std::_Bind_simple<void (*(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::shared_ptr<mir::dispatch::ThreadedDispatcher::ThreadShutdownRequestHandler>, std::shared_ptr<mir::dispatch::MultiplexingDispatchable>, std::function<void ()>))(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::shared_ptr<mir::dispatch::ThreadedDispatcher::ThreadShutdownRequestHandler>, std::shared_ptr<mir::dispatch::Dispatchable>, std::function<void ()> const&)> >::_M_run() (thread:115)
==12888== by 0x66B6D1F: ??? (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.21)
==12888== by 0x6B9E6A9: start_thread (pthread_create.c:333)
==12888== by 0x6EBBEEC: clone (clone.S:109)
[ FAILED ] FD leak was detected

[Michał Sawicz (saviq)]

Syncing task from Mir.