Fuel for OpenStack

[fuel-qa] Clean up ntp-related fuel-qa helpers

Bug #1523537 reported by Alexandr Kostrikov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Alexander Kurenyshev
Fuel for OpenStack 9.0
8.0.x
Fix Released
High
Alexander Kurenyshev
Fuel for OpenStack 8.0
Mitaka
Fix Released
High
Alexander Kurenyshev
Fuel for OpenStack 9.0

Bug Description

We need to clean up ntp related stuff in https://github.com/openstack/fuelqa/blob/master/fuelweb_test/helpers/ntp.py

There is hardcode and duplication in fuel-qa codebase regarding ntp.

That should be rewritten to use right time/ntp workflow, clean methods.

See original description
Tags: area-qa
Revision history for this message
Roman Prykhodchenko (romcheg) wrote :

Please add details of what should be done to the description.

Changed in fuel:
status: New → Incomplete
Alexandr Kostrikov (akostrikov-mirantis)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (master)

Fix proposed to branch: master
Review: https://review.openstack.org/255326

Changed in fuel:
status: Incomplete → In Progress
Revision history for this message
Alexandr Kostrikov (akostrikov-mirantis) wrote :

We should reuse code from fuel-devops

Changed in fuel:
assignee: Alexandr Kostrikov (akostrikov-mirantis) → Alexander Kurenyshev (akurenyshev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/258447

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (master)

Reviewed: https://review.openstack.org/258447
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=03159d5cfb740ec1fb41420d3867a2477f31b2d1
Submitter: Jenkins
Branch: master

commit 03159d5cfb740ec1fb41420d3867a2477f31b2d1
Author: Alexander Kurenyshev <email address hidden>
Date: Wed Dec 16 13:39:22 2015 +0300

    Clean up ntp-related fuel-qa helpers

    Add calls to the native devops ntp functions.
    Remove nested classes with ntp support from fuel-qa

    Rebased
    Closes-Bug: 1523537

    Change-Id: If7da2bed456109018bb8c53e704f7c6c26eb4561

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-qa (master)

Change abandoned by Alexandr Kostrikov (<email address hidden>) on branch: master
Review: https://review.openstack.org/255326
Reason: Will continue my work on it based on https://review.openstack.org/#/c/258447

Tatyanka (tatyana-leontovich)
Changed in fuel:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (stable/8.0)

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/276143

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (stable/8.0)

Reviewed: https://review.openstack.org/276143
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=9d0a583b599ef2872d4fc1960d02699ffd3bf2a5
Submitter: Jenkins
Branch: stable/8.0

commit 9d0a583b599ef2872d4fc1960d02699ffd3bf2a5
Author: Alexander Kurenyshev <email address hidden>
Date: Wed Dec 16 13:39:22 2015 +0300

    Clean up ntp-related fuel-qa helpers

    Add calls to the native devops ntp functions.
    Remove nested classes with ntp support from fuel-qa

    Rebased
    Closes-Bug: 1523537

    Change-Id: If7da2bed456109018bb8c53e704f7c6c26eb4561
    (cherry picked from commit 03159d5cfb740ec1fb41420d3867a2477f31b2d1)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (stable/7.0)

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/331706

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (stable/7.0)

Reviewed: https://review.openstack.org/331706
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=4d8256eaca1c80546a1b42d874caf508e760f0f7
Submitter: Jenkins
Branch: stable/7.0

commit 4d8256eaca1c80546a1b42d874caf508e760f0f7
Author: Alexander Kurenyshev <email address hidden>
Date: Wed Dec 16 13:39:22 2015 +0300

    Clean up ntp-related fuel-qa helpers

    Add calls to the native devops ntp functions.
    Remove nested classes with ntp support from fuel-qa

    Rebased
    Closes-Bug: 1523537

    Change-Id: If7da2bed456109018bb8c53e704f7c6c26eb4561
    (cherry picked from commit 03159d5cfb740ec1fb41420d3867a2477f31b2d1)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (stable/6.1)

Fix proposed to branch: stable/6.1
Review: https://review.openstack.org/341414

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (stable/6.1)

Reviewed: https://review.openstack.org/341414
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=e4d86a7773fdfafdf760cdb22245380ae413a8e6
Submitter: Jenkins
Branch: stable/6.1

commit e4d86a7773fdfafdf760cdb22245380ae413a8e6
Author: Alexander Kurenyshev <email address hidden>
Date: Wed Dec 16 13:39:22 2015 +0300

    Clean up ntp-related fuel-qa helpers

    Add calls to the native devops ntp functions.
    Remove nested classes with ntp support from fuel-qa

    Rebased
    Closes-Bug: 1523537

    Change-Id: If7da2bed456109018bb8c53e704f7c6c26eb4561
    (cherry picked from commit 03159d5cfb740ec1fb41420d3867a2477f31b2d1)
    (cherry picked from commit 4d8256e)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.