bagpipe driver: need to pass base network info to agent on all bgpvpn create/update

[Thomas Morin]

When a port is reported up by the agent, and the port network/router is not associated to a BGPVPN, the driver currently does not send any RPC to the agent.

It should always send base port network (network_id, mac_address, ip_address, gateway_ip) or else on a later create_bgpvpn, or update_bgpvpn, the agent will not have this information.

[Mathieu Rohon (mathieu-rohon)]

I'm not sure to perfectly understand the bug. Can you describe how to reproduce it?

[Thomas Morin (tmmorin-orange)]

The problem would arise in the following sequence:
- network A is not associated with any BGPVPN
- port is created on network A
- (the bagpipe BGPVPN driver does nothing, the agent does nothing related to BGPVPNs)
- network A is associated to a BGPVPN
- the driver sends a 'create_bgpvpn' RPC, informing all agents that network A has new RT import/exports for IPVPNs
- the agents would like to plug the port in a VRF, but will miss base network information (network_id, mac_address, ip_address, gateway_ip)
- FAIL

The network_id, mac_address and ip_address could be retrieved by the agent from get_device_details, but we would still miss gateway_ip. Sending everything in the BGPVPN RPC allows to avoid making too many RPCs.

[Thomas Morin (tmmorin-orange)]

https://review.openstack.org/#/c/254606/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/254606
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=0daf44bb6d850640260ed55bca0394afaefef055
Submitter: Jenkins
Branch: master

commit 0daf44bb6d850640260ed55bca0394afaefef055
Author: Thomas Morin <email address hidden>
Date: Tue Dec 8 09:14:13 2015 +0100

    bagpipe: always pass network info to the agent

    We currently need to send 'network_id', 'mac_address', 'ip_address',
    'gateway_ip' to the agent, even in the absence of a BGPVPN bound
    to the port. If we don't, this information will lack on an
    update_bgpvpn RPC.

    Change-Id: I9f6e59cc49cbe1aad7291898c867508c3b2d2b2d
    Closes-Bug: 1523398

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: backport/kilo
Review: https://review.openstack.org/254772

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/254772
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=c561baaebc64c69032e5b4ccae21ee509d6528b1
Submitter: Jenkins
Branch: backport/kilo

commit c561baaebc64c69032e5b4ccae21ee509d6528b1
Author: Mathieu Rohon <email address hidden>
Date: Mon Dec 7 23:53:21 2015 +0000

    Fix devstack plugin for kilo

    This patch makes the bgpvpn devstack plugin to configure the bgpvpn
    service provider in the neutron.conf

    Change-Id: Ie4775dc3a745b45715921109bce6000b23cfb688
    Closes-bug: 1523398

[Thomas Morin (tmmorin-orange)]

Disregard #5 and #6, https://review.openstack.org/254772 is unrelated to this bug (bogus "Closes-Bug:...")

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: backport/juno
Review: https://review.openstack.org/265215

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/265215
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=758bfa2bd39380a5a6f175eaa69f7cd27676ba6c
Submitter: Jenkins
Branch: backport/juno

commit 758bfa2bd39380a5a6f175eaa69f7cd27676ba6c
Author: Mathieu Rohon <email address hidden>
Date: Mon Dec 7 23:53:21 2015 +0000

    Fix devstack plugin for kilo

    This patch makes the bgpvpn devstack plugin to configure the bgpvpn
    service provider in the neutron.conf

    (cherry picked from commit c561baaebc64c69032e5b4ccae21ee509d6528b1)
    Change-Id: Ie4775dc3a745b45715921109bce6000b23cfb688
    Closes-bug: 1523398