Validator doesn't check that chosen nodes are already deployed

Bug #1523131 reported by Sergey Novikov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Sergey Slipushenko

Bug Description

Validator doesn't check that chosen nodes are already deployed(in case when user manually run 'execute')

ISO #239

STR:
   1. Prepare cluster
   2. Try to apply config to node in discover state

expected result: Raise readable error message
actual result: http://pastebin.com/SngFEBzh

Changed in fuel:
assignee: nobody → Fuel Mixed (fuel-mixed-team)
tags: added: area-python feature-openstack-config-change team-mixed
Changed in fuel:
assignee: Fuel Mixed (fuel-mixed-team) → Sergey Slipushenko (sslypushenko)
status: New → Confirmed
Changed in fuel:
importance: Undecided → High
milestone: none → 8.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/255795

Changed in fuel:
status: Confirmed → In Progress
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/255795
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=3286353ca0c505053c8719497fc820d465819e3a
Submitter: Jenkins
Branch: master

commit 3286353ca0c505053c8719497fc820d465819e3a
Author: sslypushenko <email address hidden>
Date: Thu Dec 10 13:08:06 2015 +0200

    Openstack configuration can not be updated in not ready nodes

    Add check that configuration update can not be executed if
    any of target nodes are not in 'ready' state.

    Current solution is:

    - If any deployment is running, then uploading new
    configurations, deleting old ones and execution updates are prohibited
    in order to keep cluster configuration in a consistent state

    - By default Execute update can be done successfully, only if
    cluster is in state 'operational' and *all* target nodes to update
    are in the state 'ready'.

    - 'force' flag allows to execute update configuration only on target
    nodes which is currently in state 'ready'. Other target nodes will be
    ignored. We assume that, these nodes nodes will get an updated
    configuration during deployment.

    Change-Id: I2ef06b7084b0cafa576172c9f2db40aa4ccd6db8
    Closes-bug: #1523131

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/258607
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=1c66fee11bebf9e66db81f3d937ffaeacef28fd6
Submitter: Jenkins
Branch: master

commit 1c66fee11bebf9e66db81f3d937ffaeacef28fd6
Author: sslypushenko <email address hidden>
Date: Wed Dec 16 18:18:34 2015 +0200

    Add --force option to OpenStack config update command

    Both v1 and v2 clients are fixed

    Closes-bug: #1526871
    Related-Bug: #1523131

    Depends-on: I2ef06b7084b0cafa576172c9f2db40aa4ccd6db8

    Change-Id: I5c9594f0ce65c893a5d7d2c7424533c7a36d4f2d

Revision history for this message
Ksenia Svechnikova (kdemina) wrote :

Verify with ISO 307:

[root@nailgun ~]# fuel openstack-config --execute --env 1 --node-id 1
400 Client Error: Bad Request (No nodes in status 'ready')
[root@nailgun ~]#

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.