Validator doesn't check that uploaded data has YAML format

Bug #1523130 reported by Sergey Novikov
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Sergey Slipushenko

Bug Description

Validator doesn't check that uploaded data has YAML format

ISO #239

STR:

   1. Prepare cluster
   2. Try to upload a config. yaml http://pastebin.com/Pyyit1kd
       [root@nailgun ~]# fuel openstack-config --env 1 --upload --file w2.yaml

expected result: Raise readable error message
actual result: http://pastebin.com/qiazTTuu

Changed in fuel:
assignee: nobody → Fuel Mixed (fuel-mixed-team)
tags: added: area-python feature-openstack-config-change team-mixed
Changed in fuel:
assignee: Fuel Mixed (fuel-mixed-team) → Sergey Slipushenko (sslypushenko)
status: New → Confirmed
Changed in fuel:
importance: Undecided → High
milestone: none → 8.0
Revision history for this message
Sergey Slipushenko (sslypushenko) wrote :

It looks like it common way how python-fuelclient works. To ensure this, you can try to upload network configuration with the same content. It fails with the same error

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/254875

Changed in fuel:
status: Confirmed → In Progress
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/254875
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=563191bd7bcf86a0ff553d3f0cacf22885517653
Submitter: Jenkins
Branch: master

commit 563191bd7bcf86a0ff553d3f0cacf22885517653
Author: sslypushenko <email address hidden>
Date: Tue Dec 8 19:07:44 2015 +0200

    Add validataion for uploaded files

    If user upload yaml of json file, client should validate that file
    has correct format.

    Change-Id: I5d9f5966da49cff1f034b17c1bbf8eafed758b31
    Closes-bug: #1523130

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Ksenia Svechnikova (kdemina) wrote :

Verify steps from the issue with ISO#288

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.