Validator doesn't check that passed configuration (puppet resources names) are supported

Bug #1523128 reported by Sergey Novikov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Sergey Slipushenko

Bug Description

Validator doesn't check that passed configuration (puppet resources names) are supported

ISO #239

STR:
   1. Prepare cluster
   2. Try to upload a config. yaml http://pastebin.com/Kdmc8SKC
       [root@nailgun ~]# fuel openstack-config --env 1 --upload --file w1.yaml

expected result: Raise readable error message
actual result: Openstack configuration with id 2 has been uploaded from file 'w1.yaml'

Changed in fuel:
assignee: nobody → Fuel Mixed (fuel-mixed-team)
tags: added: area-python feature-openstack-config-change team-mixed
Changed in fuel:
status: New → Confirmed
assignee: Fuel Mixed (fuel-mixed-team) → Sergey Slipushenko (sslypushenko)
Changed in fuel:
importance: Undecided → High
milestone: none → 8.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/254438

Changed in fuel:
status: Confirmed → In Progress
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/254438
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=45dd11f5de604c93fedc5baec8046b661088b797
Submitter: Jenkins
Branch: master

commit 45dd11f5de604c93fedc5baec8046b661088b797
Author: sslypushenko <email address hidden>
Date: Tue Dec 8 01:02:54 2015 +0200

    Raise error if upload not supported OpenStack config

    If user tries to upload not supported OpenStack configuration,
    nailgun returns 400 HTTP error with proper reason.

    Change-Id: Ie93f76d420c97a6555cfff4d6f56c71c2de7a71b
    Closes-Bug: #1523128

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Ksenia Svechnikova (kdemina) wrote :

Verify with ISO 307:

[root@nailgun ~]# fuel openstack-config --file ser.yaml --env 1 --upload
400 Client Error: Bad Request (Configurations 'bla_bla_config' can not be updated)

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.