security-group-rule-create help should describe ICMP type/code in port-range-min/max

[Akihiro Motoki]

In security-group-rule, port-range-min/max are interpreted as ICMP type/code if a given protocol is ICMP. The help message of security-group-rule-create should describe it.

The description of --protocol also should be improved. It should show available protocol names.

$ neutron security-group-rule-create --help

[...]

  --protocol PROTOCOL Protocol of packet.
  --port-range-min PORT_RANGE_MIN
                        Starting port range.
  --port-range-max PORT_RANGE_MAX
                        Ending port range.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/256858

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/256858
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=95881a080fc4c6e19344fd0d83cdc76a7acf4353
Submitter: Jenkins
Branch: master

commit 95881a080fc4c6e19344fd0d83cdc76a7acf4353
Author: Manjeet Singh Bhatia <email address hidden>
Date: Fri Dec 11 22:41:44 2015 +0000

    Add protocol value options to sg-rule-create

    This patch will show choices of allowed protocols for security group
    rule create and also indicate type and code in help when protocol is
    ICMP.

    DocImpact

    '[0-255]' values are allowed for protocol but not listed anywhere in
    description for creating security group rule.

    Change-Id: Ib79be78c253332e27991795e8add370ae351e9a6
    Closes-Bug: #1523063

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/python-neutronclient 4.0.0 release.