UpdateDeployment on non-controller roles can leave packages not updated

[James Slagle]

Even after UpdateDeployment has triggered yum_update.sh, and puppet has also run to update packages it knows about, there are scenarios where some packages may still not be updated on the non-controller role nodes.

libvirt-python is one example. It requires a minimum version of libvirt. When yum-update.sh runs with --exclude libvirt-daemon-config-nwlter --exclude libvirt-daemon-kvm, the updated version of libvirt ends up getting excluded as well, which means the update of libvirt-python is also excluded, so it's not updated.

Later when puppet runs with ensure=>latest, it updates the packages it knows about. However, it only knows to to update libvirt-daemon-config-nwlter and libvirt-daemon-kvm. Updating those 2 packages does not pull in the latest libvirt-python, therefore libvirt-python is left at the older version.

given that libvirt-python is a dependency of openstack-nova-compute, we probably should be updating it.

[James Slagle (james-slagle)]

i'm thinking that we just do another yum update run with no --exclude specified after puppet has run in a new SoftwareDeployment.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/253699

[Dan Prince (dan-prince)]

Alternate solution posted here: https://review.openstack.org/261041

[OpenStack Infra (hudson-openstack)]

Change abandoned by James Slagle (<email address hidden>) on branch: master
Review: https://review.openstack.org/253699

[Brad P. Crochet (brad-9)]

This is still an issue.

[Marios Andreou (marios-b)]

any more info than that Brad please - which packages are not being updated ? We already have the fix from Dan at https://review.openstack.org/#/c/261041/

[Brad P. Crochet (brad-9)]

@marios Sorry about the terseness. I was in a rush. :)

Anyway, I think slagle has identified the problem with the actual update. The DeployIdentifier was not being refreshed, therefore puppet wasn't even being run.

I'm testing out a fix now, and as long as that works, we might actually have this completely fixed.

[Marios Andreou (marios-b)]

ack thanks @brad.. any more info if there is any would be appreciated when you get it.

BTW is this in any way related to https://bugzilla.redhat.com/show_bug.cgi?id=1384640 I thought they might be? (assigned to you in BZ but that may be coincidental)

[Brad P. Crochet (brad-9)]

@marios Precisely that.

I have proposed a fix.

https://review.openstack.org/386617

That only fixes the client. I will be opening a separate bug for a puppet issue that was uncovered due to this.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387531

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/386617
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=63f926d8a0b5c7b6e952c7023fbacf687bb03645
Submitter: Jenkins
Branch: master

commit 63f926d8a0b5c7b6e952c7023fbacf687bb03645
Author: Brad P. Crochet <email address hidden>
Date: Fri Oct 14 09:38:19 2016 -0400

    Refresh DeployIdentifier as well on update

    The package update was not refreshing the DeployIdentifier, so puppet
    was never actually running. This adds the DeployIdentifier to the
    heat update call.

    Change-Id: I102c935e618e822c41e1201cdbb8e243ff8421af
    Depends-On: I1be83f88be1959885c980ab4f428477d412751f7
    Closes-Bug: #1522943

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/387531
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=190051454e4a7ba06998dc38d98f6bdd09303a4c
Submitter: Jenkins
Branch: stable/newton

commit 190051454e4a7ba06998dc38d98f6bdd09303a4c
Author: Brad P. Crochet <email address hidden>
Date: Fri Oct 14 09:38:19 2016 -0400

    Refresh DeployIdentifier as well on update

    The package update was not refreshing the DeployIdentifier, so puppet
    was never actually running. This adds the DeployIdentifier to the
    heat update call.

    Change-Id: I102c935e618e822c41e1201cdbb8e243ff8421af
    Depends-On: I1be83f88be1959885c980ab4f428477d412751f7
    Closes-Bug: #1522943
    (cherry picked from commit 63f926d8a0b5c7b6e952c7023fbacf687bb03645)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 5.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 5.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 5.4.0 release.