feature request for deere skin: add option to "passthrough" vinyl signal as in latenight skin

Bug #1522906 reported by Foss-4
20
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Joan

Bug Description

I might be overseeing something but I can't find any option to "pass on" or passthrough a vinyl signal. Imo this is an important option. Anybody who uses digital + vinyl will find this feature to be essential.

If you look at latenight skin at the top in the vinyl control section there's a button called "pass on". It would be lovely to integrate this vinal controls in deere as well.

Tags: skin
Revision history for this message
Foss-4 (foss-4) wrote :
Revision history for this message
Owen Williams (ywwg) wrote :

pass on == "passthrough" in mixxx. see vinyl_controls.xml in LateNight

summary: - feature request for deere skin: add option to "pass on" vinyl signal as
- in latenight skin
+ feature request for deere skin: add option to "passthrough" vinyl signal
+ as in latenight skin
Changed in mixxx:
status: New → Confirmed
Revision history for this message
Owen Williams (ywwg) wrote :

(confirmed that "passthrough" doesn't appear in the deere skin directory

jus (jus)
Changed in mixxx:
milestone: none → 2.0.1
importance: Undecided → Low
tags: added: skin
Changed in mixxx:
milestone: 2.0.1 → 2.1.0
Revision history for this message
Joan (jmigual) wrote :

There's a pull request for this bug: https://github.com/mixxxdj/mixxx/pull/939

Changed in mixxx:
assignee: nobody → Joan (jmigual)
Joan (jmigual)
Changed in mixxx:
status: Confirmed → Fix Committed
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Thanks for working on this Joan! BTW Fix Committed is only for once the PR is merged -- for now I'll leave it as In Progress.

Changed in mixxx:
status: Fix Committed → In Progress
Revision history for this message
Joan (jmigual) wrote :

Oh sorry I misunderstood the options.

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Now it is actually committed :-)

Changed in mixxx:
status: In Progress → Fix Committed
Revision history for this message
Foss-4 (foss-4) wrote :

thanks a lot Joan. fix verified.

Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8359

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.