Allow the call to auth_check_required_fields() to be only called once per session

Bug #1522660 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon

Bug Description

We call auth_check_required_fields() every time the page loads and in turn that calls every plugin to check if we have any required fields that need filling in.

When we really only need to call it once for a user per session.

For admins masquerading it might be worth having the session flag set as a per user thing - that way an admin can masquerade as a user to fill in a required field and then masquerade as another user to do the same.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5818

Aaron Wells (u-aaronw)
tags: added: auth login
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5818
Committed: https://git.mahara.org/mahara/mahara/commit/c4329032043df88b45da045b1025ca43055799b5
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c4329032043df88b45da045b1025ca43055799b5
Author: Robert Lyon <email address hidden>
Date: Fri Dec 4 16:16:05 2015 +1300

Bug 1522660: Check auth_check_required_fields() just once per session

behatnotneeded

Change-Id: Idbb6188a68253521faccd250e6968a3ad1a53052
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.