string in glance.service.js cannot control the word order in translations

Bug #1522317 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Akihiro Motoki

Bug Description

openstack_dashboard/static/app/core/openstack-service-api/glance.service.js

      return suppressError ? promise : promise.error(function() {
        toastService.add('error', gettext('Unable to delete the image with id: ') + imageId);
      });

String concatenation should not be used.
https://docs.djangoproject.com/en/1.8/topics/i18n/translation/#interpolate

Tags: i18n
Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/252827
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ed28f129d5cdd680e7b051ccac520c8304920887
Submitter: Jenkins
Branch: master

commit ed28f129d5cdd680e7b051ccac520c8304920887
Author: Akihiro Motoki <email address hidden>
Date: Thu Dec 3 17:51:06 2015 +0900

    Use interpolate in JS to allow translators to control word order

    String concatenation is not recommended for better translation.

    Closes-Bug: #1522317
    Change-Id: Ib90f8e119d330b27023f2ef05bd24b048f1045bb

Changed in horizon:
status: In Progress → Fix Released
Matthias Runge (mrunge)
Changed in horizon:
milestone: none → mitaka-3
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0b3

This issue was fixed in the openstack/horizon 9.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.