Options/Tabs, “numericUpDown” boxes, small improvement.

Bug #1522145 reported by mbm_OR
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Open Rails
Fix Released
Low
James Ross

Bug Description

This is a small improvement for Options / Tabs.
When any of the following options: Distant mountains, Advanced adhesion model, Log train speed, Automatically tune settings to keep performance level, were checked or unchecked, their “numericUpDown” boxes always stay enabled.

This patch, modifies the current, “numericUpDown” box and his label, “Enabled” state according to option “Checked” state.

Following, is a list of different tab's option menu items, included in this patch.
Options tab:
Video:
--Distant mountains [checkDistantMountains]
----Viewing distance (km) [numericDistantMountainsViewingDistance] + [label11]

Simulation:
--Advanced adhesion model [checkUseAdvancedAdhesion]
----Adhesion moving average filter size [numericAdhesionMovingAverageFilterSize] + [label12]

Evaluation
--Log train speed [checkDataLogTrainSpeed]
----Interval (sec) [numericDataLogTSInterval] + [labelDataLogTSInterval]
----checkListData [checkListDataLogTSContents]

Experimental
--Automatically tune settings to keep performance level [checkPerformanceTuner]
----target frame rate [numericPerformanceTunerTarget] + [label13]

To enable or disable each one of listed “numericUpDown” boxes, we have to add a new Click event for each of them.

It has also proceeded to rename the next labels to give them a better referenced name:
- label11 = labelDistantMountainsViewingDistance
- label12 = labelAdhesionMovingAverageFilterSize
- label13 = labelPerformanceTunerTarget

Attached is the proposed modification patch.

Revision history for this message
mbm_OR (mauribachi) wrote :
James Ross (twpol)
Changed in or:
assignee: nobody → James Ross (twpol)
status: New → Triaged
importance: Undecided → Low
milestone: none → 1.1
status: Triaged → In Progress
Revision history for this message
James Ross (twpol) wrote :

Thanks for the patch! This has been included in Open Rails version X3367.

Changed in or:
status: In Progress → Fix Committed
James Ross (twpol)
Changed in or:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.