worker/instancepoller: intermittent data race

Bug #1522001 reported by Dave Cheney
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
High
Dave Cheney

Bug Description

==================
WARNING: DATA RACE
Write by goroutine 46:
  github.com/juju/juju/provider/dummy.SetInstanceStatus()
      /home/ubuntu/juju-core_1.26-alpha3/src/github.com/juju/juju/provider/dummy/environs.go:1472 +0x7a
  github.com/juju/juju/worker/instancepoller.(*workerSuite).TestWorker()
      /home/ubuntu/juju-core_1.26-alpha3/src/github.com/juju/juju/worker/instancepoller/worker_test.go:146 +0xf63
  runtime.call16()
      /usr/lib/go/src/pkg/runtime/asm_amd64.s:338 +0x31
  reflect.Value.Call()
      /usr/lib/go/src/pkg/reflect/value.go:345 +0xaa
  gopkg.in/check%2ev1.func·003()
      /home/ubuntu/juju-core_1.26-alpha3/src/gopkg.in/check.v1/check.go:772 +0x504
  gopkg.in/check%2ev1.func·001()
      /home/ubuntu/juju-core_1.26-alpha3/src/gopkg.in/check.v1/check.go:666 +0xf3

Previous read by goroutine 122:
  github.com/juju/juju/provider/dummy.(*dummyInstance).Status()
      /home/ubuntu/juju-core_1.26-alpha3/src/github.com/juju/juju/provider/dummy/environs.go:1454 +0x3a
  github.com/juju/juju/worker/instancepoller.(*aggregator).instInfo()
      /home/ubuntu/juju-core_1.26-alpha3/src/github.com/juju/juju/worker/instancepoller/aggregate.go:110 +0x227
  github.com/juju/juju/worker/instancepoller.(*aggregator).loop()
      /home/ubuntu/juju-core_1.26-alpha3/src/github.com/juju/juju/worker/instancepoller/aggregate.go:89 +0x74a
  github.com/juju/juju/worker/instancepoller.func·005()
      /home/ubuntu/juju-core_1.26-alpha3/src/github.com/juju/juju/worker/instancepoller/aggregate.go:34 +0x86

Goroutine 46 (running) created at:
  gopkg.in/check%2ev1.(*suiteRunner).forkCall()
      /home/ubuntu/juju-core_1.26-alpha3/src/gopkg.in/check.v1/check.go:667 +0x529
  gopkg.in/check%2ev1.(*suiteRunner).forkTest()
      /home/ubuntu/juju-core_1.26-alpha3/src/gopkg.in/check.v1/check.go:804 +0x168
  gopkg.in/check%2ev1.(*suiteRunner).runTest()
      /home/ubuntu/juju-core_1.26-alpha3/src/gopkg.in/check.v1/check.go:809 +0x3e
  gopkg.in/check%2ev1.(*suiteRunner).run()
      /home/ubuntu/juju-core_1.26-alpha3/src/gopkg.in/check.v1/check.go:615 +0x44a
  gopkg.in/check%2ev1.Run()
      /home/ubuntu/juju-core_1.26-alpha3/src/gopkg.in/check.v1/run.go:92 +0x56
  gopkg.in/check%2ev1.RunAll()
      /home/ubuntu/juju-core_1.26-alpha3/src/gopkg.in/check.v1/run.go:84 +0x111
  gopkg.in/check%2ev1.TestingT()
      /home/ubuntu/juju-core_1.26-alpha3/src/gopkg.in/check.v1/run.go:72 +0x4d6
  github.com/juju/testing.MgoTestPackage()
      /home/ubuntu/juju-core_1.26-alpha3/src/github.com/juju/testing/mgo.go:354 +0x156
  github.com/juju/juju/testing.MgoTestPackage()
      /home/ubuntu/juju-core_1.26-alpha3/src/github.com/juju/juju/testing/mgo.go:15 +0x52
  github.com/juju/juju/worker/instancepoller.TestPackage()
      /home/ubuntu/juju-core_1.26-alpha3/src/github.com/juju/juju/worker/instancepoller/updater_test.go:21 +0x34
  testing.tRunner()
      /usr/lib/go/src/pkg/testing/testing.go:391 +0x10f

Goroutine 122 (running) created at:
  github.com/juju/juju/worker/instancepoller.newAggregator()
      /home/ubuntu/juju-core_1.26-alpha3/src/github.com/juju/juju/worker/instancepoller/aggregate.go:35 +0x143
  github.com/juju/juju/worker/instancepoller.(*updaterWorker).loop()
      /home/ubuntu/juju-core_1.26-alpha3/src/github.com/juju/juju/worker/instancepoller/worker.go:51 +0x134
  github.com/juju/juju/worker/instancepoller.func·008()
      /home/ubuntu/juju-core_1.26-alpha3/src/github.com/juju/juju/worker/instancepoller/worker.go:33 +0x86
==================
OK: 21 passed
PASS
Found 1 data race(s)
FAIL github.com/juju/juju/worker/instancepoller 37.210s

Changed in juju-core:
status: New → Triaged
importance: Undecided → High
Changed in juju-core:
assignee: nobody → Dave Cheney (dave-cheney)
status: Triaged → In Progress
Changed in juju-core:
milestone: none → 1.26-alpha3
status: In Progress → Fix Committed
Changed in juju-core:
status: Fix Committed → In Progress
Changed in juju-core:
status: In Progress → Fix Committed
Changed in juju-core:
milestone: 1.26-alpha3 → 2.0-alpha1
Changed in juju-core:
milestone: 2.0-alpha1 → 1.26-alpha3
Curtis Hovey (sinzui)
tags: added: race-condition tech-debt
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
tags: added: 2.0-count
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.