Can't update user password if encrypt_parameters_and_properties enabled

Bug #1521925 reported by huangtianhua
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
huangtianhua
Liberty
Fix Released
Medium
huangtianhua

Bug Description

1. create a stack with keystone user resource with the template:
****************************************
heat_template_version: 2016-04-08
parameters:
  pw:
    type: string
    hidden: true
resources:
  t_p:
    type: OS::Keystone::User
    properties:
      name: 'y'
      domain: test
      default_project: demo
      password: {get_param: pw}
      groups:
        - nonadmins
****************************************

2. after the stack create complete, update the stack to change password of the user, but the stack update failed, the reason is:
ValueError: too many values to unpack, the details in: http://paste.openstack.org/show/480593/

Changed in heat:
assignee: nobody → huangtianhua (huangtianhua)
Changed in heat:
importance: Undecided → Medium
milestone: none → mitaka-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/252736

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/252736
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=2fe6deee9b2dd0d94d860b1a5fad443d865d1327
Submitter: Jenkins
Branch: master

commit 2fe6deee9b2dd0d94d860b1a5fad443d865d1327
Author: huangtianhua <email address hidden>
Date: Thu Dec 3 09:45:35 2015 +0800

    Make sure update successful if there is encrypt param

    Don't append the param in env.encrypted_param_names again
    when encrypt hidden paramters, otherwise an error will raise
    when get template from db-object before decrypting.

    Closes-Bug: #1521925
    Change-Id: I4bdaa3391863cd18a451da4eee0cb9314c0057c5

Changed in heat:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/257190

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/liberty)

Reviewed: https://review.openstack.org/257190
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=faacb526969d3ed8575fff0802b469d3ccdad264
Submitter: Jenkins
Branch: stable/liberty

commit faacb526969d3ed8575fff0802b469d3ccdad264
Author: huangtianhua <email address hidden>
Date: Thu Dec 3 09:45:35 2015 +0800

    Make sure update successful if there is encrypt param

    Don't append the param in env.encrypted_param_names again
    when encrypt hidden paramters, otherwise an error will raise
    when get template from db-object before decrypting.

    Closes-Bug: #1521925
    Change-Id: I4bdaa3391863cd18a451da4eee0cb9314c0057c5
    (cherry picked from commit 2fe6deee9b2dd0d94d860b1a5fad443d865d1327)

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/heat 6.0.0.0b2

This issue was fixed in the openstack/heat 6.0.0.0b2 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

This issue was fixed in the openstack/heat 6.0.0.0b2 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/heat 5.0.1

This issue was fixed in the openstack/heat 5.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.