BasicSurface::set_cursor_image can create references to null pointers
Bug #1521795 reported by
Alberto Aguirre
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Medium
|
Alberto Aguirre | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Creating references to null pointers is undefined behavior.
This can happen if a client disables the cursor on a surface via:
auto conf = mir_cursor_
mir_surface_
Related branches
lp:~albaguirre/mir/fix-1521795
- PS Jenkins bot (community): Approve (continuous-integration)
- Kevin DuBois (community): Approve
- Alan Griffiths: Approve
-
Diff: 230 lines (+96/-2)11 files modifiedinclude/server/mir/scene/null_surface_observer.h (+1/-0)
include/server/mir/scene/surface_observer.h (+1/-0)
include/test/mir/test/doubles/stub_cursor_image.h (+42/-0)
src/include/server/mir/scene/surface_observers.h (+1/-0)
src/server/input/cursor_controller.cpp (+4/-0)
src/server/scene/basic_surface.cpp (+11/-2)
src/server/scene/legacy_surface_change_notification.cpp (+4/-0)
src/server/scene/legacy_surface_change_notification.h (+1/-0)
src/server/scene/null_surface_observer.cpp (+1/-0)
src/server/symbols.map (+1/-0)
tests/unit-tests/scene/test_basic_surface.cpp (+29/-0)
Changed in mir: | |
milestone: | 0.19.0 → 0.18.0 |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.19.0