firewall resource replaced with value_specs during update

[Rabi Mishra]

Updating OS::Neutron:Firewall resource with value_specs replaces the resource.

How to reproduce:

1. Create firewall resource with

heat_template_version: 2015-04-30
description: Template to test neutron firewall resource
resources:
  firewall:
    type: OS::Neutron::Firewall
    properties:
      name: test-firewall
      firewall_policy_id: ab4462a6-d824-45d0-9f91-4fb2ce054041
      admin_state_up: True
      shared: True

2. Update with

heat_template_version: 2015-04-30
description: Template to test neutron firewall resource
resources:
  firewall:
    type: OS::Neutron::Firewall
    properties:
      name: test-firewall
      firewall_policy_id: ab4462a6-d824-45d0-9f91-4fb2ce054041
      admin_state_up: True
      shared: True
      value_specs:
         router_ids:
           - 4fc37ab3-e0a8-46a7-b8c5-b654a1080182

This would replace the firewall resource. However, this should allow to update the firewall resource[1] as this property update is allowed by neutron[1].

https://github.com/openstack/neutron-fwaas/blob/master/neutron_fwaas/extensions/firewallrouterinsertion.py#L31

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/252159

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/252159
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=4e39eb030087378ed5803fed557294f14645da87
Submitter: Jenkins
Branch: master

commit 4e39eb030087378ed5803fed557294f14645da87
Author: Rabi Mishra <email address hidden>
Date: Tue Dec 1 21:04:02 2015 +0530

    Make value_specs updatable for firewall resource

    Adds update_allowed=True for value_specs property.

    Change-Id: I1c455a2d7aef22d265dac622a59f8cf3f736e025
    Closes-Bug: #1521670

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/heat 6.0.0.0b2 development milestone.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/heat 6.0.0.0b2 development milestone.