gate-networking-ofagent-pep8 job fails

Bug #1521542 reported by fumihiko kakuma
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-ofagent
Fix Released
Undecided
fumihiko kakuma

Bug Description

gate-networking-ofagent-pep8 job fails by the following error.

2015-12-01 06:17:24.416 | pep8 runtests: commands[2] | pylint --rcfile=.pylintrc --output-format=colorized networking_ofagent
2015-12-01 06:17:24.417 | /home/jenkins/workspace/gate-networking-ofagent-pep8$ /home/jenkins/workspace/gate-networking-ofagent-pep8/.tox/pep8/bin/pylint --rcfile=.pylintrc --output-format=colorized networking_ofagent
2015-12-01 06:17:24.697 | Warning: option ignore-iface-methods is obsolete and it is slated for removal in Pylint 1.6.
2015-12-01 06:17:31.438 | ************* Module networking_ofagent.plugins.ofagent.agent.main
2015-12-01 06:17:31.438 | C: 21, 0: standard import "import sys" comes before "from ryu.lib import hub" (wrong-import-order)
2015-12-01 06:17:31.439 | C: 24, 0: Imports from package ryu are not grouped (ungrouped-imports)
2015-12-01 06:17:31.644 | ERROR: InvocationError: '/home/jenkins/workspace/gate-networking-ofagent-pep8/.tox/pep8/bin/pylint --rcfile=.pylintrc --output-format=colorized networking_ofagent'
2015-12-01 06:17:31.644 | ___________________________________ summary ____________________________________
2015-12-01 06:17:31.644 | ERROR: pep8: commands failed
2015-12-01 06:17:31.685 | + rc=1

The whole log can be got from the following:
http://logs.openstack.org/53/251653/1/check/gate-networking-ofagent-pep8/ccc8e34/console.html

The latest pylint considers an import order in ofagent an error.
This error need to be fixed in all ofaagent releases.

Revision history for this message
fumihiko kakuma (kakuma) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/#/c/251615/

Changed in networking-ofagent:
assignee: nobody → fumihiko kakuma (kakuma)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-ofagent (master)

Reviewed: https://review.openstack.org/251615
Committed: https://git.openstack.org/cgit/openstack/networking-ofagent/commit/?id=4dad45b50a228b69eae2962c8270a1c77df89f46
Submitter: Jenkins
Branch: master

commit 4dad45b50a228b69eae2962c8270a1c77df89f46
Author: fumihiko kakuma <email address hidden>
Date: Tue Dec 1 12:03:22 2015 +0900

    Fix a pep8 error for an import order in ofagent

    Closes-Bug: #1521542
    Change-Id: Ic1b1f363e3aac642e8e77dc09368df117a7d4827

Changed in networking-ofagent:
status: New → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-ofagent (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/252166

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-ofagent (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/252167

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-ofagent (stable/liberty)

Reviewed: https://review.openstack.org/252166
Committed: https://git.openstack.org/cgit/openstack/networking-ofagent/commit/?id=392818deb92ae8ae447ea2532279929f1d69bd96
Submitter: Jenkins
Branch: stable/liberty

commit 392818deb92ae8ae447ea2532279929f1d69bd96
Author: fumihiko kakuma <email address hidden>
Date: Tue Dec 1 12:03:22 2015 +0900

    Fix a pep8 error for an import order in ofagent

    Closes-Bug: #1521542
    Change-Id: Ic1b1f363e3aac642e8e77dc09368df117a7d4827
    (cherry picked from commit 4dad45b50a228b69eae2962c8270a1c77df89f46)

tags: added: in-stable-liberty
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-ofagent (stable/kilo)

Reviewed: https://review.openstack.org/252167
Committed: https://git.openstack.org/cgit/openstack/networking-ofagent/commit/?id=b6e0a93b57c7c8dbcef86d9bf248b3454d3f8861
Submitter: Jenkins
Branch: stable/kilo

commit b6e0a93b57c7c8dbcef86d9bf248b3454d3f8861
Author: fumihiko kakuma <email address hidden>
Date: Tue Dec 1 12:03:22 2015 +0900

    Fix a pep8 error for an import order in ofagent

    Closes-Bug: #1521542
    Change-Id: Ic1b1f363e3aac642e8e77dc09368df117a7d4827
    (cherry picked from commit 4dad45b50a228b69eae2962c8270a1c77df89f46)

tags: added: in-stable-kilo
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/networking-ofagent 2015.1.6

This issue was fixed in the openstack/networking-ofagent 2015.1.6 release.

fumihiko kakuma (kakuma)
Changed in networking-ofagent:
status: Fix Committed → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/networking-ofagent 1.0.3

This issue was fixed in the openstack/networking-ofagent 1.0.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.