[Dashboard] Unexpected behavior of fields in apps

[Tatiana Kholkina]

Steps to reproduce:
1. Choose an app which has few fields with type 'string', e.g. Docker Standalone Host.
2. Change type from 'string' to 'text' for on of the fields, e.g. DockerMirror.
3. Import uploaded package and run 'Quick deploy'
Now we have large field for docker mirror. But we also have a large field for hostname on the next form.

I have found that it happens because we assign value to static variable 'widget' of class Field (CharField):
https://github.com/openstack/murano-dashboard/blob/9f652cc878c9d72ef809bb770463732cedd4c999/muranodashboard/dynamic_ui/forms.py#L68

And then all next fields have widget Textarea instead of default TextInput.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/251739

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/251739
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=88abc05d2401c1b3e163502923611c7d03c88d35
Submitter: Jenkins
Branch: master

commit 88abc05d2401c1b3e163502923611c7d03c88d35
Author: Tetiana Lashchova <email address hidden>
Date: Tue Dec 1 11:33:45 2015 +0200

    Do not assign a value to the class variable 'widget'

    Class variable 'widget' stores a default widget for CharField.
    It is dangerous to change it. This patch fixes this and assigns
    a value to instance variable.

    Change-Id: I7220dcacd64aeee096e9340dc49bb4c5ebcfefd5
    Closes-Bug: #1521535

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/254674

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/254681

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/254681
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=b126c5e5c1b83e21bcbb1782cf0b1c3460abac7e
Submitter: Jenkins
Branch: stable/kilo

commit b126c5e5c1b83e21bcbb1782cf0b1c3460abac7e
Author: Tetiana Lashchova <email address hidden>
Date: Tue Dec 1 11:33:45 2015 +0200

    Do not assign a value to the class variable 'widget'

    Class variable 'widget' stores a default widget for CharField.
    It is dangerous to change it. This patch fixes this and assigns
    a value to instance variable.

    Change-Id: I7220dcacd64aeee096e9340dc49bb4c5ebcfefd5
    Closes-Bug: #1521535
    (cherry picked from commit 88abc05d2401c1b3e163502923611c7d03c88d35)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/254674
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=b23495f95ad19c04bbd0e011bd308d89f60d2db7
Submitter: Jenkins
Branch: stable/liberty

commit b23495f95ad19c04bbd0e011bd308d89f60d2db7
Author: Tetiana Lashchova <email address hidden>
Date: Tue Dec 1 11:33:45 2015 +0200

    Do not assign a value to the class variable 'widget'

    Class variable 'widget' stores a default widget for CharField.
    It is dangerous to change it. This patch fixes this and assigns
    a value to instance variable.

    Change-Id: I7220dcacd64aeee096e9340dc49bb4c5ebcfefd5
    Closes-Bug: #1521535
    (cherry picked from commit 88abc05d2401c1b3e163502923611c7d03c88d35)

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/murano-dashboard 2015.1.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/murano-dashboard 2015.1.1 release.