bay-show command always return "0" in bay_create_timeout

Bug #1521146 reported by Shu Muto
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Committed
Wishlist
Yang Hongyang

Bug Description

When bay created with timeout option as below, bay creation timed out.

magnum bay-create --name k8sbay_timeout --baymodel k8sbaymodel --node-count 1 --timeout 1

But bay-show command gets always "0" for bay_create_timeout from magnum API.

Below is magnumclient's log in bay-show for above bay.

RESP BODY: {"status": "CREATE_FAILED", "uuid": "f46e8fa4-cfde-4832-a910-676ec0f2665c", "links": [{"href": "http://192.168.10.31:9511/v1/bays/f46e8fa4-cfde-4832-a910-676ec0f2665c", "rel": "self"}, {"href": "http://192.168.10.31:9511/bays/f46e8fa4-cfde-4832-a910-676ec0f2665c", "rel": "bookmark"}], "updated_at": "2015-11-30T10:47:44+00:00", "created_at": "2015-11-30T10:46:41+00:00", "api_address": null, "discovery_url": "https://discovery.etcd.io/6da639920f5ea8aeb0f01c7fc58dea07", "master_count": 1, "baymodel_id": "48210be2-4a7c-4f0f-8e67-d8e5fbb5e552", "node_count": 1, "node_addresses": [], "status_reason": "Create timed out", "bay_create_timeout": 0, "name": "k8sbay_timeout"}

yuanying (yuanying)
Changed in magnum:
assignee: nobody → yuanying (ootsuka)
importance: Undecided → Wishlist
Revision history for this message
Yang Hongyang (hongyang-yang) wrote :

Currently 'bay_create_timeout' is only useful on bay creation, and its value is not stored in database, so when we doing bay-show, it always 0, I think there're two ways to fix this:
1. store 'bay_create_timeout' value in database
2. do not show 'bay_create_timeout' when doing bay-show

I don't know if its worth to add 'bay_create_timeout' coloumn to database because this only
matters when doing bay creation.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/252263

Changed in magnum:
assignee: yuanying (ootsuka) → Yang Hongyang (hongyang-yang)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/252263
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=f0749cc56c106aa6b9cc64dd8bcb9230bbda3962
Submitter: Jenkins
Branch: master

commit f0749cc56c106aa6b9cc64dd8bcb9230bbda3962
Author: Yang Hongyang <email address hidden>
Date: Wed Dec 2 16:54:56 2015 +0800

    Add missing bay_create_timeout to bay object

    Currently bay-show command always shows "0" in bay_create_timeout, this
    is confusing for users, store bay_create_timeout into db so that bay-show
    will return correct bay_create_timeout value.

    Change-Id: Icaea11d7d298bd6245a50c464bff6ff20292e092
    Closes-Bug: #1521146

Changed in magnum:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/magnum 2.0.0

This issue was fixed in the openstack/magnum 2.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.