Support migration of non-HA router to HA and reverse

[Ann Taraday]

Updating a legacy router to HA and vice versa succeeds on the server side, but the L3 agent does not support this operation.

A reasonable goal would be to require users to perform an upgrade as such:

neutron router-update <r> --admin-state-up=False
neutron router-update <r> --ha=True
neutron router-update <r> --admin-state-up=True

(This is the same upgrade procedure for distributed routers).

Upstream bug https://bugs.launchpad.net/neutron/+bug/1365426

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-8.0/liberty
Change author: John Schwarz <email address hidden>
Review: https://review.fuel-infra.org/14261

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/14261
Submitter: Pkgs Jenkins <email address hidden>
Branch: openstack-ci/fuel-8.0/liberty

Commit: dc17a9166f1ce6228ecf27e8a63dbc41bc79f198
Author: John Schwarz <email address hidden>
Date: Thu Dec 17 05:40:20 2015

Support migrating of legacy routers to HA and back

This patch adds support for migration of legacy routers to HA and
vice-versa. This patch also:

1. Reverts I4171ab481e3943e0110bd9a300d965bbebe44871, which was used to
   disable such migrations until support was inserted to the codebase.
2. Adds an exception to indicate that such migrations are only available
   on routers that have their admin_state_up set to False.

Closes-Bug: #1520579
DocImpact (Handled in patch 233695)
Change-Id: Ie92f8033f47e1bf9ba6310373b3bfc9833317580
Partially-Implements blueprint:neutron-vrrp-deployment
(cherry pick from commit 416c76bc6e01ef433506e4aa4ebd7c76b57acc51)

[Kristina Berezovskaia (kkuznetsova)]

Verify on
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "429"
  build_id: "429"
  fuel-nailgun_sha: "12b15b2351e250af41cc0b10d63a50c198fe77d8"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "df16d41cd7a9445cf82ad9fd8f0d53824711fcd8"
  fuel-nailgun-agent_sha: "92ebd5ade6fab60897761bfa084aefc320bff246"
  astute_sha: "c7ca63a49216744e0bfdfff5cb527556aad2e2a5"
  fuel-library_sha: "3eaf4f4a9b88b287a10cc19e9ce6a62298cc4013"
  fuel-ostf_sha: "214e794835acc7aa0c1c5de936e93696a90bb57a"
  fuel-mirror_sha: "b62f3cce5321fd570c6589bc2684eab994c3f3f2"
  fuelmenu_sha: "85de57080a18fda18e5325f06eaf654b1b931592"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "9f0ba4577915ce1e77f5dc9c639a5ef66ca45896"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "e8e36cff332644576d7853c80b8a53d5b955420a"
(vxlan+l3 ha, 3 controllers, 2 compute)

Steps:
1) Create router with ha False, net, subnet, boot vm
neutron net-create net09
neutron subnet-create net09 --name net09__subnet 10.9.1.0/24
neutron router-create router09 --ha False
neutron router-interface-add router09 net09__subnet
neutron router-gateway-set router09 admin_floating_net
NET2_ID=$(neutron net-list | grep 'net09' | awk '{print $2}')
nova boot vm_net_09 --flavor m1.micro --image TestVM --nic net-id=$NET2_ID
2) check that router is scheduled on one controller
3) Update it to l3 ha True
neutron router-update router09 --admin-state-up=False
neutron router-update router09 --ha=True
neutron router-update router09 --admin-state-up=True
4) check that router is scheduled on all controllers and one of them is ACTIVE
5) ban active agent
6) check pings and that another agent becomes ACTIVE