Turn off slip mode when loading a new track to prevent jumps to unpredictable play positions

Bug #1520531 reported by jus
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Owen Williams

Bug Description

Tested with latest 2.0 branch

We should turn off the slip_enabled control for a deck when loading a new track to the deck.

Currently, if you activate the control, it stays active until manually deactivated. This can lead to train wrecks.

Steps to reproduce:
* Load a track and start playback
* Activate slip mode
* Load a new track to the deck
* Start playback
* Deactivate slip mode

Actual result:
Playing track jumps to unpredictable position, possible to the tracks end

Expected result
Deactivate slip on load

Revision history for this message
Owen Williams (ywwg) wrote :

should be an easy fix

Changed in mixxx:
assignee: nobody → Owen Williams (ywwg)
Revision history for this message
Owen Williams (ywwg) wrote :

https://github.com/mixxxdj/mixxx/pull/787/files

Just want someone to doublecheck my multithreading

Changed in mixxx:
status: New → In Progress
Revision history for this message
jus (jus) wrote :

Thanks for the fast fix.

Changed in mixxx:
milestone: none → 2.0.0
importance: Undecided → Low
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8341

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.