Risk is hard to predict when use the tenant list in orchestrator

[Yu Zhiguo]

There is the same issue like bug 1512560 exist in orchestrator when get the tenant list that will be rated. The process method in orchestrator include the following processing logic: modify (remove some items) the sequence (self._tenants) being iterated over in the loop, which may cause unpredictable result.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/250172

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/250172
Committed: https://git.openstack.org/cgit/openstack/cloudkitty/commit/?id=819e89f306433b7d80a3fd46f0b542b37b619b85
Submitter: Jenkins
Branch: master

commit 819e89f306433b7d80a3fd46f0b542b37b619b85
Author: Yu Zhiguo <email address hidden>
Date: Thu Nov 26 21:21:19 2015 +0800

    The result of tenant list may be unpredictable

    A problem like bug 1512560 existed in orchestrator when determinate
    which tenants will be rated in the next period:
    The process method in orchestrator include the following processing
    logic: modify (remove some items) the sequence (self._tenants) being
    iterated over in the loop, which may cause unpredictable result.
    This patch fixed this problem as the same way as solving bug 1512560.

    Change-Id: Id148c5a0a1ab0290cfff02d9121badcb7f4e6ac7
    Closes-Bug: #1520068

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/cloudkitty 0.5.0 release.