Controller script loader always uses local copy

[Sean M. Pappalardo]

As I update controller scrips, I'm editing the file in /res/controllers and running Mixxx with --resourcePath res/

I repeatedly tell it to reload the preset (choosing the second of the same name in the list because I know the first is my local copy) and the XML is updated correctly, but if a copy of the JS file is in my ~/.mixxx directory, it uses that regardless. I have to manually delete that copy in order for it to try using the copy in res/.

This is serious because it will cause all kinds of problems when users try to load updated presets after upgrading.

[Owen Williams (ywwg)]

if we already do the right thing with respect to XML, then we should definitely fix this for js.

[Owen Williams (ywwg)]

which preset? There is code that is supposed to do the right thing in dlgprefcontroller.cpp:380.

[Owen Williams (ywwg)]

reproduced, working on this now

[Owen Williams (ywwg)]

So the problem is that when the user picks an item from the preset menu, the listitem contains the full path of the preset to import -- either the user's preset, or the system preset. But the scripts are loaded dynamically, and it looks first in the user's dir, and if it finds the script, it's done.

To fix this, we have to know which preset they are loading and load the script from the same path.

Should we put up a warning box when presets are loaded, indicating that users might lose customization?

[Owen Williams (ywwg)]

oh, hah, we increment the filename, no need to warn the user

[Owen Williams (ywwg)]

https://github.com/mixxxdj/mixxx/commit/e47ff9018705dcc1c3fa6220b693103ea7711cf4

[Sean M. Pappalardo (pegasus-renegadetech)]

Sweet, thanks for the quick fix!

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8339