Controller update for 2.0: Hercules DJ Control MP3 e2

Bug #1519953 reported by Owen Williams
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Undecided
Sébastien BLAISOT

Bug Description

This is a certified mapping and needs to be up to date so it will work smoothly with Mixxx. Notably the following things need to be checked and updated if necessary:

• Effects COs need to be changed
• EQ COs need to be updated
• Sync button needs to be tested with push-and-hold
• 4 decks need to be supported if the controller adapts easily (don't force 4-deck support into a 2-deck controller)

Revision history for this message
Sébastien BLAISOT (sblaisot) wrote :

I have already updated this one : https://github.com/mixxxdj/mixxx/pull/590

I have also corrected HID mapping : https://github.com/mixxxdj/mixxx/pull/667

Effects CO:
Switched flanger to [QuickEffectRack1_[ChannelX]],super1

EQ CO:
Switched low/mid/high to [EqualizerRack1_[ChannelX]_Effect1], parameter1/2/3
Switched filter to [EqualizerRack1_X_Effect1], control

Sync button:
Added sync_enabled on "tempo" button
Sync button is "beatsync"
Added led logic to tempo button:
- off -> sync_enabled==0
- on -> sync_enabled==1
- code commented out to blink when "master" (see comment in the file

4-deck support added

see also updated wiki page: http://www.mixxx.org/wiki/doku.php/hercules_dj_control_mp3_e2

Changed in mixxx:
status: New → Fix Committed
assignee: nobody → Sébastien BLAISOT (sblaisot)
Revision history for this message
Owen Williams (ywwg) wrote :

sync button needs to be sync_enabled. Please see http://www.mixxx.org/wiki/doku.php/updating_controllers_for_2.0 where we are working on documenting all of the required changes

Revision history for this message
Sébastien BLAISOT (sblaisot) wrote :

I'm not sure to understand what you mean.
Do you mant mapping to mimic the GUI with a short press just syncing with the other track and a long press setting sync_enabled to 1 ?

This controller has 2 buttons for this :
one is called "master tempo" and is designed to enabling autosync on a deck
the other one is called "sync" and is designed to be a one-shot sync

I thinks it's better to have a mapping as close as possible to what's written on the buttons, but if you really want me to change this, I will do it, just let me know.

Changed in mixxx:
status: Fix Committed → In Progress
Revision history for this message
Owen Williams (ywwg) wrote :

oh I guess if it has two separate buttons that's ok. We'll have to update the manual though, right now it talks about long-pressing.

Revision history for this message
Owen Williams (ywwg) wrote :

let's call this done for now, and we can reopen if we need to tweak it

Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8329

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.