Fuel for OpenStack

After browser window resize header layout is broken

Bug #1519375 reported by Alexandra Morozova on 2015-11-24

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Fuel for OpenStack	Fix Released	Low	Vitaly Kramskikh	Fuel for OpenStack 8.0

Bug Description

str:
1. Resize browser window to obtain horizontal scroll.
2. got to the right

Expected result: header is full-width

Actual: header is cropped http://take.ms/1c3kl

Tags:

Julia Aranovich (jkirnosova) on 2015-11-24

Changed in fuel:
status:	New → Confirmed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-12-04: Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/253364

Changed in fuel:
assignee:	Fuel UI Team (fuel-ui) → Dmitry Bilunov (dbilunov)
status:	Confirmed → In Progress

Revision history for this message

Dmitry Bilunov (dbilunov) wrote on 2015-12-04:

Another instance of this bug Edit (90.8 KiB, image/png)

OpenStack Infra (hudson-openstack) on 2015-12-08

Changed in fuel:
assignee:	Dmitry Bilunov (dbilunov) → Vitaly Kramskikh (vkramskikh)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-12-08: Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/253364
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=a6fff4f3d14a09ab933c0de08442e5dbdd3d1d1b
Submitter: Jenkins
Branch: master

commit a6fff4f3d14a09ab933c0de08442e5dbdd3d1d1b
Author: Dmitry Bilunov <email address hidden>
Date: Fri Dec 4 10:32:49 2015 +0300

Fix header layout after window's width has been resized down to <1285px

Bootstrap CSS sets negative margins to navbar rows, so in case we are
using more than one, successive rows are pushed to avoid overlapping.

Fuel web interface has only one navbar row, so the document layout
becomes broken when it pushes window margin beyond the viewport.

    This commit cancels out negative margin-right if the navbar row is the
    last child of its parent. It works in FF 3.5+, IE9+, Chrome 4+ and
    Safari 4+. Bug will be still observable in older browsers without
    :last-child CSS3 selector support with no other regressions caused by
    this change.

Change-Id: I48a14b2321499e74a46d8f4cd61dc0f71a10fab4
Closes-Bug: 1519375

Changed in fuel:
status:	In Progress → Fix Released

Vitaly Kramskikh (vkramskikh) on 2015-12-08

Changed in fuel:
status:	Fix Released → Fix Committed

Revision history for this message

Anastasia Palkina (apalkina) wrote on 2015-12-11:

Verified on ISO #284 on FF (version 42.0) and Chrome (version 47.0.2526.80 (64-bit))

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "284"
  build_id: "284"
  fuel-nailgun_sha: "eb187d0eed96226ca0d8c4513ffcafc4d09dee62"
  python-fuelclient_sha: "f96659066e522e28b389de3cc685f6f2aacca3da"
  fuel-agent_sha: "2f18b7596bc7da79d2f28c34f42620b2090d8a35"
  fuel-nailgun-agent_sha: "a33a58d378c117c0f509b0e7badc6f0910364154"
  astute_sha: "e8c753d6ce1405df78d032e88c0d5a1c6f3d17ce"
  fuel-library_sha: "15d966e164a8b8f7d94c70863bd1cc4990703ec8"
  fuel-ostf_sha: "632730169e8c01afe7fd5d78a898f00d4646358b"
  fuel-mirror_sha: "31b9df814960ec69b644ca9b689dacec0c7e10a1"
  fuelmenu_sha: "680b720291ff577f4c058cee25f85e563c96312e"
  shotgun_sha: "a0bd06508067935f2ae9be2523ed0d1717b995ce"
  network-checker_sha: "a3534f8885246afb15609c54f91d3b23d599a5b1"
  fuel-upgrade_sha: "1e894e26d4e1423a9b0d66abd6a79505f4175ff6"
  fuelmain_sha: "1577a306c2c9e7bd12f28c0e16cf3652997da004"