'recheck' comment on fuel-library review can lead to false-positive result from Fuel CI

Bug #1519333 reported by Igor Belikov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Critical
Igor Belikov

Bug Description

'recheck' comment retriggers only lightweight jobs for fuel-library reviews and skips deployment tests. This retrigger is considered as a new gerrit event by gerrit-trigger plugin and can lead to +1 from Fuel CI even if deployment tests previously failed.
Example: https://review.openstack.org/#/c/239693/

Tags: area-ci
Igor Belikov (ibelikov)
Changed in fuel:
status: New → Confirmed
assignee: Fuel CI (fuel-ci) → Igor Belikov (ibelikov)
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to fuel-infra/jenkins-jobs (master)

Fix proposed to branch: master
Change author: Igor Belikov <email address hidden>
Review: https://review.fuel-infra.org/14148

Changed in fuel:
status: Confirmed → In Progress
status: In Progress → Fix Committed
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to fuel-infra/jenkins-jobs (master)

Reviewed: https://review.fuel-infra.org/14148
Submitter: Igor Belikov <email address hidden>
Branch: master

Commit: 85992df8d17e294a999613d851c8bf5605fc861d
Author: Igor Belikov <email address hidden>
Date: Tue Nov 24 12:34:54 2015

Disable 'recheck' support in fuel-library jobs

'recheck' for fuel-library reviews currently triggers only
lightweight jobs and can give +1 ignoring previous failures
of deployment tests

Change-Id: If6330d5f73bb9fd9c7a5c367f843e8d78d588820
Closes-Bug: #1519333

Igor Belikov (ibelikov)
Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.