No need to check edp_engine is None

Bug #1519237 reported by lu huichun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sahara
Fix Released
Low
lu huichun

Bug Description

Because under service/validations/edp/job_execution.py, we already have check_job_execution before _run_job in job_manager.py so we don't have to check if edp_engine is None in _run_job()

lu huichun (lhcxx0508)
Changed in sahara:
assignee: nobody → lu huichun (lhcxx0508)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara (master)

Fix proposed to branch: master
Review: https://review.openstack.org/249068

Changed in sahara:
status: New → In Progress
Revision history for this message
Vitalii Gridnev (vgridnev) wrote : Re: return when cluster is None

Lu, thank you for the bug report but it's impossible to understand anything from the description. Bug report should be totally clear to allow bug manager to understand importance of bug and to triage that.

Changed in sahara:
status: In Progress → Incomplete
Changed in sahara:
status: Incomplete → In Progress
Changed in sahara:
status: In Progress → Incomplete
lu huichun (lhcxx0508)
description: updated
summary: - return when cluster is None
+ check return value of conductor.cluster_get()
Revision history for this message
Vitalii Gridnev (vgridnev) wrote : Re: check return value of conductor.cluster_get()

Thanks, that is much better

Changed in sahara:
status: Incomplete → In Progress
importance: Undecided → Low
lu huichun (lhcxx0508)
summary: - check return value of conductor.cluster_get()
+ No need to check edp_engine is None
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara (master)

Reviewed: https://review.openstack.org/249068
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=e67a9dfd931843fd062c75265e68a40da42d6359
Submitter: Jenkins
Branch: master

commit e67a9dfd931843fd062c75265e68a40da42d6359
Author: luhuichun <email address hidden>
Date: Tue Nov 24 15:56:41 2015 +0800

    Check cluster if it is None before run job

    We should check the return value of conductor.cluster_get(), if
    the return value is None, we should return directly.

    Change-Id: I55ad18b127798913878fde1d00f4e5ad7b4994c5
    Closes-Bug: #1519237

Changed in sahara:
status: In Progress → Fix Committed
Changed in sahara:
milestone: none → mitaka-1
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/sahara 4.0.0.0b1

This issue was fixed in the openstack/sahara 4.0.0.0b1 development milestone.

Changed in sahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.