worker/machiner: data race

Bug #1519145 reported by Dave Cheney
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
Medium
Dave Cheney

Bug Description

WARNING: DATA RACE
Write by goroutine 22:
  reflect.memmove()
      /usr/lib/go/src/pkg/reflect/value.go:39 +0x17a
  reflect.Value.Set()
      /usr/lib/go/src/pkg/reflect/value.go:1387 +0xfc
  github.com/juju/testing.func·020()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/testing/patch.go:48 +0x8b
  github.com/juju/testing.func·004()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/testing/cleanup.go:78 +0x45
  github.com/juju/testing.(*CleanupSuite).callStack()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/testing/cleanup.go:41 +0x81
  github.com/juju/testing.(*CleanupSuite).TearDownTest()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/testing/cleanup.go:36 +0x63
  github.com/juju/juju/testing.(*BaseSuite).TearDownTest()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/juju/testing/base.go:160 +0x6f
  github.com/juju/juju/worker/machiner_test.(*MachinerSuite).TearDownTest()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/juju/worker/machiner/machiner_test.go:1 +0x49
  runtime.call16()
      /usr/lib/go/src/pkg/runtime/asm_amd64.s:338 +0x31
  reflect.Value.Call()
      /usr/lib/go/src/pkg/reflect/value.go:345 +0xaa
  gopkg.in/check%2ev1.func·002()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/check.go:721 +0x19a
  gopkg.in/check%2ev1.func·001()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/check.go:666 +0xf3

Previous read by goroutine 21:
  github.com/juju/juju/worker/machiner.setMachineAddresses()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/juju/worker/machiner/machiner.go:105 +0x46
  github.com/juju/juju/worker/machiner.(*Machiner).SetUp()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/juju/worker/machiner/machiner.go:86 +0x64e
  github.com/juju/juju/worker.(*notifyWorker).loop()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/juju/worker/notifyworker.go:84 +0x65
  github.com/juju/juju/worker.func·003()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/juju/worker/notifyworker.go:56 +0x81

Goroutine 22 (running) created at:
  gopkg.in/check%2ev1.(*suiteRunner).forkCall()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/check.go:667 +0x529
  gopkg.in/check%2ev1.(*suiteRunner).runFunc()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/check.go:673 +0x78
  gopkg.in/check%2ev1.(*suiteRunner).runFixture()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/check.go:722 +0x77
  gopkg.in/check%2ev1.(*suiteRunner).runFixtureWithPanic()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/check.go:735 +0x9b
  gopkg.in/check%2ev1.func·003()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/check.go:804 +0x505
  gopkg.in/check%2ev1.func·001()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/check.go:666 +0xf3

Goroutine 21 (running) created at:
  github.com/juju/juju/worker.NewNotifyWorker()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/juju/worker/notifyworker.go:57 +0x117
  github.com/juju/juju/worker/machiner.NewMachiner()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/juju/worker/machiner/machiner.go:66 +0x150
  github.com/juju/juju/worker/machiner_test.(*MachinerSuite).TestMachinerConfigValidate()
      /home/ubuntu/juju-core_1.26-alpha2/src/github.com/juju/juju/worker/machiner/machiner_test.go:64 +0x491
  runtime.call16()
      /usr/lib/go/src/pkg/runtime/asm_amd64.s:338 +0x31
  reflect.Value.Call()
      /usr/lib/go/src/pkg/reflect/value.go:345 +0xaa
  gopkg.in/check%2ev1.func·003()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/check.go:772 +0x504
  gopkg.in/check%2ev1.func·001()
      /home/ubuntu/juju-core_1.26-alpha2/src/gopkg.in/check.v1/check.go:666 +0xf3
==================
OK: 14 passed
PASS
Found 1 data race(s)
FAIL github.com/juju/juju/worker/machiner 65.600s

Changed in juju-core:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Dave Cheney (dave-cheney) wrote :

This only appears to be a race under go 1.2, 1.4 and tip don't care.

Changed in juju-core:
status: Triaged → In Progress
assignee: nobody → Dave Cheney (dave-cheney)
Changed in juju-core:
status: In Progress → Fix Committed
milestone: none → 1.26-alpha3
Changed in juju-core:
milestone: 1.26-alpha3 → 2.0-alpha1
Changed in juju-core:
milestone: 2.0-alpha1 → 1.26-alpha3
Curtis Hovey (sinzui)
tags: added: tech-debt
tags: added: race-condition
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
tags: added: 2.0-count
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.