The database user variable is incorrect

Bug #1519040 reported by Sam Yaple
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
Medium
Sam Yaple
Liberty
Fix Released
Medium
Sam Yaple

Bug Description

The database variable used to check if the command was successfully or not is incorrect. This leads to a very rare case where we will get the nasty unparsable json error again.

Sam Yaple (s8m)
Changed in kolla:
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.openstack.org/248837

Changed in kolla:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/248839

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/liberty)

Reviewed: https://review.openstack.org/248839
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=8ef21e14e986b5aa447450af4d0939857d737a8e
Submitter: Jenkins
Branch: stable/liberty

commit 8ef21e14e986b5aa447450af4d0939857d737a8e
Author: Sam Yaple <email address hidden>
Date: Sat Nov 7 16:40:17 2015 +0000

    Incorrect parsed variable name

    database_user_create was not correctly referenced when parsing the
    variable names. This could never actually lead to a situation that
    reported a false change, but it could break an operation if you were
    using the --step option with ansible and skipped the database create
    task.

    TrivialFix
    Backport: Liberty

    Partial-Bug: #1519040
    Change-Id: Idf69fffcc3814f509448ccea11b7d175f074ccf1
    (cherry picked from commit 6b283430173caf0d0ecabce55dfa62abfe68787a)

tags: added: in-stable-liberty
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.openstack.org/248837
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=97a8ba6fd7f0f59aa392573ba9d7107d92f2880d
Submitter: Jenkins
Branch: master

commit 97a8ba6fd7f0f59aa392573ba9d7107d92f2880d
Author: Sam Yaple <email address hidden>
Date: Mon Nov 23 17:37:04 2015 +0000

    Fix incorrect ansible variable

    Change-Id: Ic6755dfe5c3741e4a945c8353f643bbf1479c172
    Closes-Bug: #1519040

Changed in kolla:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/248960

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/liberty)

Reviewed: https://review.openstack.org/248960
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=99d6c08877b8a1760a9249e3d0a3dce254703c46
Submitter: Jenkins
Branch: stable/liberty

commit 99d6c08877b8a1760a9249e3d0a3dce254703c46
Author: Sam Yaple <email address hidden>
Date: Mon Nov 23 17:37:04 2015 +0000

    Fix incorrect ansible variable

    Change-Id: Ic6755dfe5c3741e4a945c8353f643bbf1479c172
    Closes-Bug: #1519040
    (cherry picked from commit 97a8ba6fd7f0f59aa392573ba9d7107d92f2880d)

Sam Yaple (s8m)
Changed in kolla:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.