Version Matching and comparison must be done consistently in manila tempest tests

[Goutham Pacha Ravi]

Going forward, we'll be performing a ton of version checks within manila_tempest_tests:

In the manila core code, we sanitize the comparisons:

 https://github.com/openstack/manila/blob/b4611145/manila/api/openstack/api_version_request.py

Since we can't reference a class within manila itself, we should have a helper definition exclusively in manila_tempest_tests.

And wherever necessary, we should:
0) Always accept micro version as a string
1) Split the micro version into major and minor portions.
3) Either use the ComparableMixin (make a copy from manila/utils: https://github.com/openstack/manila/blob/b4611145/manila/utils.py)

or,
3) Perform comparison on major version and then,
4) Perform comparison on minor version.

 https://github.com/openstack/manila/blob/b4611145/manila/api/openstack/api_version_request.py

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/257480

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/257480
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=bdf2045d95d6bccf45d991bbbd7236cb27ace2ac
Submitter: Jenkins
Branch: master

commit bdf2045d95d6bccf45d991bbbd7236cb27ace2ac
Author: Valeriy Ponomaryov <email address hidden>
Date: Mon Dec 14 18:48:15 2015 +0200

    Fix microversion comparison approach in functional tests

    Manila microversions have following template:

    x.y

    where 'x' and 'y' both digits.

    And now manilaclient functional tests transform string 'x.y' to float,
    but it is incorrect thing to do because float assumes that each
    left value is bigger than right one. And it is not suitable
    for microversion comparisons.

    Examples:

    Microversions true conditions:
    2.9 < 2.10
    2.9 < 2.81

    Float true conditions:
    2.9 > 2.10
    2.9 > 2.81

    Change-Id: Ibb20e394cefdab82f7be946ce710a6681224051d
    Closes-bug: #1518996

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/257459
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=afeb366fd30fea70c7de905e54b39347bc411edc
Submitter: Jenkins
Branch: master

commit afeb366fd30fea70c7de905e54b39347bc411edc
Author: Valeriy Ponomaryov <email address hidden>
Date: Mon Dec 14 18:06:13 2015 +0200

    Fix Tempest microversion comparison approach

    Manila microversions have following template:

    x.y

    where 'x' and 'y' both digits.

    And now tempest transforms string 'x.y' to float but it is incorrect
    thing to do because float assumes that each left value is bigger than
    right one. And it is not suitable for microversion comparisons.

    Examples:

    Microversions true conditions:
    2.9 < 2.10
    2.9 < 2.81

    Float true conditions:
    2.9 > 2.10
    2.9 > 2.81

    So, create new file 'manila_tempest_tests/utils.py' and place there
    old and new functions that serve all microversion actions. In addition,
    port another existing utility function called 'rand_ip'.

    Change-Id: I88bf2cb51fd8de1bc89bf169bda7a05ca5a0b8ab
    Closes-Bug: #1518996

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/manila 2.0.0.0b2 development milestone.