Delete stack can get stuck due to uncaught exception

[Andrey Epifanov]

Backport of https://bugs.launchpad.net/heat/+bug/1386213

Customers often face this issue on production environments.
Pretty big stacks are not able to be deleted and consume a lot of resources.
Unfortunately we don't have a suitable workaround for this. Only manual modifying of BD helps here.

[Sergey Kraynev (skraynev)]

Patch for 5.1.1 https://review.fuel-infra.org/#/c/13961/

[Sergey Kraynev (skraynev)]

Both patches are already merged for 7.0, so we do not need to port anything else to 7.0 branch

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-5.1.1-updates/2014.1.1
Change author: tengqm <email address hidden>
Review: https://review.fuel-infra.org/14135

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Sergey Kraynev <email address hidden> on branch: openstack-ci/fuel-5.1/2014.1.1
Review: https://review.fuel-infra.org/13961
Reason: Abandoned in favor of https://review.fuel-infra.org/#/c/14135/

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-6.0-updates/2014.2
Change author: tengqm <email address hidden>
Review: https://review.fuel-infra.org/14138

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-6.1/2014.2
Change author: tengqm <email address hidden>
Review: https://review.fuel-infra.org/14139

[Vitaly Sedelnik (vsedelnik)]

Retargeted to 6.1-mu-5 because of delayed reviews

[Vitaly Sedelnik (vsedelnik)]

Invalid for 7.0-updates per feedback from Heat the fix is already in 7.0 branch

[Roman Rufanov (rrufanov)]

Customer found on MOS 5.1

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/14138
Submitter: Denis V. Meltsaykin <email address hidden>
Branch: openstack-ci/fuel-6.0-updates/2014.2

Commit: 5ac6ca2be00cf1f17ff232fb678833d02144fc71
Author: tengqm <email address hidden>
Date: Mon Feb 15 13:44:50 2016

Prevent using long password for crypting trust

Check if encoded user credential may get truncated.

In some deployments, user passwords are generated by other
authentication infrastructures where the length of the Base64 encoded
credentials is longer than the DB limit.

This patch checks if the encoded credential might be truncated when
it is generated and fail early during stack creation, or else it will
cause troubles later on when operating the stack.

Don't block stack deletion if user creds fail.

In some deployments, user passwords are generated by other
authentication infrastructures where the length of the Base64 encoded
credentials is longer than the DB limit. When this incorrect behavior
happens silently, the user credential can not be retrieved.
In this case, stack deletion will abort due to uncaught exception.

This patch enables a stack deletion to handle this error so that stack
can be properly deleted.

Closes-Bug: #1518903
(cherry picked from commit 0d9af5c6833e26532bf798ebd0756e93d674b7fc)
(cherry picked from commit 9698da68040b0e3ac63c23e72f31d9739c76e03e)

Change-Id: Icc05b300542006c3306530949e9fa6726d76589c

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/14139
Submitter: Vitaly Sedelnik <email address hidden>
Branch: openstack-ci/fuel-6.1/2014.2

Commit: e073a2760b94b9da6d34a032d0b435102eb02702
Author: tengqm <email address hidden>
Date: Tue Dec 8 11:48:49 2015

Prevent using long password for crypting trust

Check if encoded user credential may get truncated

In some deployments, user passwords are generated by other
authentication infrastructures where the length of the Base64 encoded
credentials is longer than the DB limit.

This patch checks if the encoded credential might be truncated when
it is generated and fail early during stack creation, or else it will
cause troubles later on when operating the stack.

Don't block stack deletion if user creds fail

In some deployments, user passwords are generated by other
authentication infrastructures where the length of the Base64 encoded
credentials is longer than the DB limit. When this incorrect behavior
happens silently, the user credential can not be retrieved.
In this case, stack deletion will abort due to uncaught exception.

This patch enables a stack deletion to handle this error so that stack
can be properly deleted.

Closes-Bug: #1518903
(cherry picked from commit 0d9af5c6833e26532bf798ebd0756e93d674b7fc)
(cherry picked from commit 9698da68040b0e3ac63c23e72f31d9739c76e03e)

Change-Id: Icc05b300542006c3306530949e9fa6726d76589c

[Dmitry (dtsapikov)]

Bug was not reproduced before the patch was applied.
After updating I had exception that was added in the patch https://paste.mirantis.net/show/1915/

[Dmitry (dtsapikov)]

Bug was not reproduced on 6.1+mu5 before the patch was applied.
After updating I had exception that was added in the patch https://paste.mirantis.net/show/1915/

[Sergey Kraynev (skraynev)]

Fix was proposed and just need to be tested / merged https://review.fuel-infra.org/#/c/14135/

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/14135
Submitter: Sergey Kraynev <email address hidden>
Branch: openstack-ci/fuel-5.1.1-updates/2014.1.1

Commit: c329b62eee7836c9c829895d9015725979e952d5
Author: tengqm <email address hidden>
Date: Wed Jul 6 11:24:58 2016

Prevent using long password for crypting trust

Check if encoded user credential may get truncated

In some deployments, user passwords are generated by other
authentication infrastructures where the length of the Base64 encoded
credentials is longer than the DB limit.

This patch checks if the encoded credential might be truncated when
it is generated and fail early during stack creation, or else it will
cause troubles later on when operating the stack.

Don't block stack deletion if user creds fail

In some deployments, user passwords are generated by other
authentication infrastructures where the length of the Base64 encoded
credentials is longer than the DB limit. When this incorrect behavior
happens silently, the user credential can not be retrieved.
In this case, stack deletion will abort due to uncaught exception.

This patch enables a stack deletion to handle this error so that stack
can be properly deleted.

Closes-Bug: #1518903
(cherry picked from commit 0d9af5c6833e26532bf798ebd0756e93d674b7fc)
(cherry picked from commit 9698da68040b0e3ac63c23e72f31d9739c76e03e)

Change-Id: Icc05b300542006c3306530949e9fa6726d76589c