test_assign_ip_multiple_groups fails sometimes

[Valentin Kaplov]

Next test
nailgun.test.integration.test_network_manager.TestNetworkManager#test_assign_ip_multiple_groups fails if run integration tests. If run the test separately, then it passed successfully.

##################################
            self.assertIn(
                IPAddress(ip.ip_addr),
> IPNetwork(mgmt_net.cidr)
            )
E AssertionError: IPAddress('9.9.9.1') not found in IPNetwork('192.168.0.0/24')
##################################

[Ilya Kutukov (ikutukov)]

It seems to be some accumulated state provoking this issue.
Is it possible to determine what test or test group that run before causes test_assign_ip_multiple_groups failure?

[Valentin Kaplov (vkaplov)]

Not sure, but looks like after run once unit tests the issue comes out.
Issue go away after cleanuping db.
####
python manage.py dropdb
python manage.py syncdb
####

[Valentin Kaplov (vkaplov)]

still reproduces
http://logs.openstack.org/73/252873/27/check/gate-fuel-web-python27/c3e3f07/console.html

[Aleksey Kasatkin (alekseyk-ru)]

https://ci.fuel-infra.org/job/verify-fuel-web-py27/3671/console

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/262552

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/262552
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=7ad94b754d5b1faabbad265a16932a1411e55812
Submitter: Jenkins
Branch: master

commit 7ad94b754d5b1faabbad265a16932a1411e55812
Author: Igor Kalnitsky <email address hidden>
Date: Wed Dec 30 17:23:48 2015 +0200

    Fix test_assign_ip_multiple_groups random failures

    Recently the test 'test_assign_ip_multiple_groups' has a random failure
    that was depended on the order of entries selected from database. The
    test had two errors:

    * It didn't change network's CIDR, so node's IP address was checked
      for containing with incorrect (old) CIDR.
    * The new IP range was created, but old ones weren't removed. So when
      IP allocation code picked old IP range - the test is passed; when
      the new IP range is picked - the test is failed.

    Change-Id: Ib792ea1e4910a568d8bf44c6c6ba8afff0402b3f
    Closes-Bug: #1518268

[Artem Roma (aroma-x)]

Move to confirmed since there is no backport to 8.0 branch.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/269570

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/269570
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=8897592b93362b1b1f913700e6e3516277bffb70
Submitter: Jenkins
Branch: stable/8.0

commit 8897592b93362b1b1f913700e6e3516277bffb70
Author: Igor Kalnitsky <email address hidden>
Date: Wed Dec 30 17:23:48 2015 +0200

    Fix test_assign_ip_multiple_groups random failures

    Recently the test 'test_assign_ip_multiple_groups' has a random failure
    that was depended on the order of entries selected from database. The
    test had two errors:

    * It didn't change network's CIDR, so node's IP address was checked
      for containing with incorrect (old) CIDR.
    * The new IP range was created, but old ones weren't removed. So when
      IP allocation code picked old IP range - the test is passed; when
      the new IP range is picked - the test is failed.

    Change-Id: Ib792ea1e4910a568d8bf44c6c6ba8afff0402b3f
    Closes-Bug: #1518268
    (cherry picked from commit 7ad94b754d5b1faabbad265a16932a1411e55812)

[Artem Roma (aroma-x)]

Fix was merged to stable/8.0w branch hence I move this bug to 'fix committed' status