(gtk3) GtkDialog mapped without a transient parent.

[Egmont Koblinger]

Each time the Preferences window is opened, this is printed to stderr:

Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.

I've no clue what it means, but recently gnome-terminal received some relevant changes (https://git.gnome.org/browse/gnome-terminal/log/, 2015-05-10). This also implies this must be pretty new in Gtk, probably appeared in 3.16, maybe 3.14.

[Stephen Boddy (stephen-j-boddy)]

Yup. Doesn't happen in 3.10. Now I know you're on a very recent GTK.

[Egmont Koblinger (egmont-gmail)]

I'm using Wily, and whichever Gtk is shipped by that.

[Stephen Boddy (stephen-j-boddy)]

So that looks to be 3.16.

[Egmont Koblinger (egmont-gmail)]

As far as I understand:

This recommendation was made with "typical" apps in mind that have a single main window. The prefs dialog is recommended to be modal for that (i.e. always on top of that).

In case of terminator, especially with bug 1520838 in mind, the question is: on top of which terminator window? For the one it was opened from? And if that window is closed (but another terminator window is still open), what should happen to the prefs dialog?

Apparently gnome-terminal's main developer might have had the same dilemma, and also thought that this recommendation doesn't make too much sense for g-t. So he decided to take the opposite path. Instead of obeying this recommendation, he got rid of the warning by changing the prefs and profile prefs dialogs from GtkDialog to GtkWindow.

Unfortunately it's not as simple as changing these six letters in the glade file. I haven't dug further into the details yet, but g-t's changes are a good starting point.

[Egmont Koblinger (egmont-gmail)]

Actually changing GtkDialog to GtkWindow would only take 4 letters :D

[Egmont Koblinger (egmont-gmail)]

Here's a tiny fix that already works.

The paddings (especially around the "Close" button) have changed a bit.

Also, pressing Escape no longer closes the window (g-t suffers from the same problem: https://bugzilla.gnome.org/show_bug.cgi?id=758867).

[Stephen Boddy (stephen-j-boddy)]

Committed revision 1678.