update rule name failing in the test

[Lin Hua Cheng]

Failed to update rule new name: Unexpected method call. unexpected:- expected:+
- function.__call__(<class 'django.http.HttpRequest'>, 'h0881d38-c3eb-4fee-9763-12de3338041d', action=u'ALLOW', description=u'new desc', destination_ip_address=None, destination_port=u'1:65535', enabled=True, ip_version=u'', name=u'new name', protocol=u'ICMP', shared=False, source_ip_address='1.2.3.0/24', source_port=None) -> None
+ function.__call__(mox.IsA(<class 'django.http.request.HttpRequest'>) , 'h0881d38-c3eb-4fee-9763-12de3338041d', action='ALLOW', description='new desc', destination_ip_address=None, destination_port='1:65535', enabled=True, name='new name', protocol='ICMP', shared=False, source_ip_address='1.2.3.0/24', source_port=None) -> <Rule: {'protocol': 'ANY', 'description': 'rule3 description', 'policy': None, 'tenant_id': '1', 'enabled': True, 'rule_id': 'h0881d38-c3eb-4fee-9763-12de3338041d', 'source_ip_address': '1.2.3.0/24', 'destination_ip_address': '4.5.6.7/32', 'firewall_policy_id': None, 'action': 'ALLOW', 'position': None, 'source_port': '80', 'shared': True, 'destination_port': '1:65535', 'id': 'h0881d38-c3eb-4fee-9763-12de3338041d', 'name': 'rule3'}>
..Failed to update rule new name: Unexpected method call. unexpected:- expected:+
- function.__call__(<class 'django.http.HttpRequest'>, 'f0881d38-c3eb-4fee-9763-12de3338041d', action=u'ALLOW', description=u'new desc', destination_ip_address=None, destination_port=u'1:65535', enabled=True, ip_version=u'', name=u'new name', protocol=u'ICMP', shared=False, source_ip_address='1.2.3.0/24', source_port=None) -> None
+ function.__call__(mox.IsA(<class 'django.http.request.HttpRequest'>) , 'f0881d38-c3eb-4fee-9763-12de3338041d', action='ALLOW', description='new desc', destination_ip_address=None, destination_port='1:65535', enabled=True, name='new name', protocol='ICMP', shared=False, source_ip_address='1.2.3.0/24', source_port=None) -> <Rule: {'protocol': 'TCP', 'description': 'rule1 description', 'policy': <Policy: {'description': 'policy with two rules', 'firewall_rules': ['f0881d38-c3eb-4fee-9763-12de3338041d', 'c6298a93-850f-4f64-b78a-959fd4f1e5df'], 'rules': [<Rule: {...}>, <Rule: {'protocol': 'udp', 'description': '', 'policy': <Policy: {...}>, 'tenant_id': '1', 'enabled': True, 'source_ip_address': '1.2.3.0/24', 'destination_ip_address': '4.5.6.7/32', 'firewall_policy_id': 'abcdef-c3eb-4fee-9763-12de3338041e', 'action': 'deny', 'position': 2, 'source_port': '80', 'shared': True, 'destination_port': '1:65535', 'id': 'c6298a93-850f-4f64-b78a-959fd4f1e5df', 'name': ''}>], 'tenant_id': '1', 'id': 'abcdef-c3eb-4fee-9763-12de3338041e', 'shared': True, 'audited': True, 'name': 'policy1'}>, 'tenant_id': '1', 'enabled': True, 'rule_id': 'f0881d38-c3eb-4fee-9763-12de3338041d', 'source_ip_address': '1.2.3.0/24', 'destination_ip_address': '4.5.6.7/32', 'firewall_policy_id': 'abcdef-c3eb-4fee-9763-12de3338041e', 'action': 'ALLOW', 'position': 1, 'source_port': '80', 'shared': True, 'destination_port': '1:65535', 'id': 'f0881d38-c3eb-4fee-9763-12de3338041d', 'name': 'rule1'}>
.Failed to update rule new name: Unexpected method call. unexpected:- expected:+
- function.__call__(<class 'django.http.HttpRequest'>, 'f0881d38-c3eb-4fee-9763-12de3338041d', action=u'ALLOW', description=u'new desc', destination_ip_address=None, destination_port=u'1:65535', enabled=True, ip_version=u'', name=u'new name', protocol=None, shared=False, source_ip_address='1.2.3.0/24', source_port=None) -> None
+ function.__call__(mox.IsA(<class 'django.http.request.HttpRequest'>) , 'f0881d38-c3eb-4fee-9763-12de3338041d', action='ALLOW', description='new desc', destination_ip_address=None, destination_port='1:65535', enabled=True, name='new name', protocol=None, shared=False, source_ip_address='1.2.3.0/24', source_port=None) -> <Rule: {'protocol': 'TCP', 'description': 'rule1 description', 'policy': <Policy: {'description': 'policy with two rules', 'firewall_rules': ['f0881d38-c3eb-4fee-9763-12de3338041d', 'c6298a93-850f-4f64-b78a-959fd4f1e5df'], 'rules': [<Rule: {...}>, <Rule: {'protocol': 'udp', 'description': '', 'policy': <Policy: {...}>, 'tenant_id': '1', 'enabled': True, 'source_ip_address': '1.2.3.0/24', 'destination_ip_address': '4.5.6.7/32', 'firewall_policy_id': 'abcdef-c3eb-4fee-9763-12de3338041e', 'action': 'deny', 'position': 2, 'source_port': '80', 'shared': True, 'destination_port': '1:65535', 'id': 'c6298a93-850f-4f64-b78a-959fd4f1e5df', 'name': ''}>], 'tenant_id': '1', 'id': 'abcdef-c3eb-4fee-9763-12de3338041e', 'shared': True, 'audited': True, 'name': 'policy1'}>, 'tenant_id': '1', 'enabled': True, 'rule_id': 'f0881d38-c3eb-4fee-9763-12de3338041d', 'source_ip_address': '1.2.3.0/24', 'destination_ip_address': '4.5.6.7/32', 'firewall_policy_id': 'abcdef-c3eb-4fee-9763-12de3338041e', 'action': 'ALLOW', 'position': 1, 'source_port': '80', 'shared': True, 'destination_port': '1:65535', 'id': 'f0881d38-c3eb-4fee-9763-12de3338041d', 'name': 'rule1'}>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/247280

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/247280
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=64a127fbd71734682f546d635e508404ab3391ab
Submitter: Jenkins
Branch: master

commit 64a127fbd71734682f546d635e508404ab3391ab
Author: lin-hua-cheng <email address hidden>
Date: Wed Nov 18 19:10:04 2015 -0800

    Fix mocks on update firewall rule tests

    The new ip_version attribute was not added to existing
    tests.

    Change-Id: I55555a4ccdd4759154197e5e7a9a01e6ab207463
    Closes-Bug: #1517670

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/horizon 9.0.0.0b1 development milestone.