event action is incorrect for handling resource signals

[Pratik Mallya]

http://git.openstack.org/cgit/openstack/heat/tree/heat/engine/resource.py#n1652

The event action should be the resource action, as the signal is meaningless unless we know the action and state of the resource that is being signalled.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/246481

[Steven Hardy (shardy)]

For as long as I can remember this has been the case (probably since we first implemented resource signalling, but I've not checked the code history).

I get why you'd like to change it, but IMHO this cannot happen until we do a new API revision (and even then we'll need a way to ensure backwards compatibility.

On balance, I don't believe the benefit outweighs the risk of breaking users in this case.

[Pratik Mallya (pratik-mallya)]

(Adding motivation for this bug):

This discrepancy was noticed when I was implementing resource notifications. So, for resource events its straightforward since notifications map almost exactly to events. But for hooks and signals, its different, since the nature of the events are indicated only by the 'reason' parameter.

Its easy enough to write separate notifications, I was hoping to make it similar to stack notifications, where all add_event methods have been replaced by send_notification_and_add_event method.

[Pratik Mallya (pratik-mallya)]

(adding blueprint for resource notifications)

https://review.openstack.org/#/c/244830/11

[OpenStack Infra (hudson-openstack)]

Change abandoned by Pratik Mallya (<email address hidden>) on branch: master
Review: https://review.openstack.org/246481
Reason: Abandoning, since the consensus is to preserve the current format, and change only in v2