UI bundle has size of more than 3 Mb

Bug #1517028 reported by Vitaly Kramskikh
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Vitaly Kramskikh

Bug Description

After switching to webpack bundle size became 3 Mb. A few things can be done to solve this.

1. Enable uglifier. We used it with require.js.

2. Enable babel-runtime to avoid helper duplication.

3. Pre-gzip results.

Andrey Maximov (maximov)
tags: added: tech-debt
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/249745

Changed in fuel:
assignee: Fuel UI Team (fuel-ui) → Vitaly Kramskikh (vkramskikh)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/254200

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/254201

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/254200
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=efed1744516393e22cad8f32b2dd7596e290f6dd
Submitter: Jenkins
Branch: master

commit efed1744516393e22cad8f32b2dd7596e290f6dd
Author: Vitaly Kramskikh <email address hidden>
Date: Mon Dec 7 16:00:24 2015 +0300

    Update JS dependencies to fix various bugs

    - Update 'ip' to fix issue with Safari
    - Update webpack to fix sourcemaps generation with uglifyjs
    - Remove uglifyjs - it's a webpack dependency and shouldn't
      be used directly

    Change-Id: I01a0afbaeb00dfa67bcdca33764744428dc6cc52
    Closes-Bug: #1519784
    Partial-Bug: #1517028

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/254201
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=f4ee02ad50b1ad7f50d903883fa906fbba10c6ce
Submitter: Jenkins
Branch: master

commit f4ee02ad50b1ad7f50d903883fa906fbba10c6ce
Author: Vitaly Kramskikh <email address hidden>
Date: Mon Dec 7 16:40:29 2015 +0300

    Enable uglification by default

    Also add new options to disable uglification and source maps
    generation

    Change-Id: I4c458abbf8bff9b9783c0cf0b46b45a96803101f
    Partial-Bug: #1517028

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-web (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/254373

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/254373
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=d51e4fcdf91d9c13b323acd88e6bd1cf4557e56a
Submitter: Jenkins
Branch: master

commit d51e4fcdf91d9c13b323acd88e6bd1cf4557e56a
Author: Vitaly Kramskikh <email address hidden>
Date: Mon Dec 7 23:27:54 2015 +0300

    Make sourcemaps work with uglification

    Change-Id: Ie0a7f79a90c43291dcd84d7d202e3099b0411962
    Related-Bug: #1517028

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/254929

Revision history for this message
Vitaly Kramskikh (vkramskikh) wrote :

After merging https://review.openstack.org/#/c/254929/ and https://review.openstack.org/#/c/254201/ size of response for bundle.js reduced from 3.2MB to 377 KB. Enabling babel-runtime actually increased the size slightly, so we decided not to enable it.

I think this issue should be considered as fixed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/254929
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=ec562eb98ef1a8249fd5daea720c0a79218c6d39
Submitter: Jenkins
Branch: master

commit ec562eb98ef1a8249fd5daea720c0a79218c6d39
Author: Vitaly Kramskikh <email address hidden>
Date: Tue Dec 8 22:53:46 2015 +0300

    Enable gzip for CSS and Javascript

    This will allow to reduce size of response for bundle.js
    from 1.7MB to 377KB.

    Change-Id: Ic3badbe8085c9d1b63503d106a7810f69d3afaf4
    Partial-Bug: #1517028

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (master)

Change abandoned by Vitaly Kramskikh (<email address hidden>) on branch: master
Review: https://review.openstack.org/249745

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.