fuel-menu creates wrong /etc/fuel-bootstrap-image.conf and breaks bootstrap image build

[Albert Syriy]

fuel-menu creates the following /etc/fuel-bootstrap-image.conf:

flavor="ubuntu"
SKIP_DEFAULT_IMG_BUILD="False"
MIRROR_DISTRO="http://archive.ubuntu.com/ubuntu"
DISTRO_RELEASE="trusty"
MIRROR_MOS="http://mirror.fuel-infra.org/mos-repos/ubuntu/8.0"
HTTP_PROXY=""
HTTPS_PROXY=""
EXTRA_DEB_REPOS="[]"
add_repo_button="None"
MOS_VERSION="8.0"
BOOTSTRAP_SSH_KEYS=/root/.ssh/id_rsa.pub

EXTRA_DEB_REPOS is wrong: it should be a pipe separated (possibly empty) list of APT URLs, like this:

EXTRA_DEB_REPOS='deb http://ru.archive.ubuntu.com/ubuntu trusty main universe multiverse | deb http://ru.archive.ubuntu.com/ubuntu trusty-updates main universe multiverse'

As a result the fuel-bootstrap-image fails to produce a bootstrap image:

=====================
+ chroot /tmp/fuel-bootstrap-image.LSYweRsyv env LC_ALL=C DEBIAN_FRONTEND=noninteractive DEBCONF_NONINTERACTIVE_SEEN=true TMPDIR=/tmp TMP=/tmp apt-get update
E: Type '[]' is not known on line 8 in source list /etc/apt/sources.list
E: The list of sources could not be read.
=====================

[Alexei Sheplyakov (asheplyakov)]

Please attach /etc/fuel-bootstrap-image.conf

> deb http://mirror.fuel-infra.org/mos-repos/ubuntu/8.0 mos8.0-holdback main
> []

This looks like an invalid config (/etc/fuel-bootstrap-image.conf)

[Albert Syriy (asyriy)]

Here the image-bootstrap-image.conf file

[Albert Syriy (asyriy)]

The EXTRA_DEB_REPOS is set to "[]"
See below
----------------
flavor="ubuntu"
SKIP_DEFAULT_IMG_BUILD="False"
MIRROR_DISTRO="http://archive.ubuntu.com/ubuntu"
DISTRO_RELEASE="trusty"
MIRROR_MOS="http://mirror.fuel-infra.org/mos-repos/ubuntu/8.0"
HTTP_PROXY=""
HTTPS_PROXY=""
EXTRA_DEB_REPOS="[]"
add_repo_button="None"
MOS_VERSION="8.0"
BOOTSTRAP_SSH_KEYS=/root/.ssh/id_rsa.pub
----------------

[Aleksey Zvyagintsev (azvyagintsev)]

Duplicate
https://bugs.launchpad.net/fuel/+bug/1516571

[Alexei Sheplyakov (asheplyakov)]

> EXTRA_DEB_REPOS="[]"

This is obviously wrong - EXTRA_DEB_REPOS should be a pipe ('|') separated (possibly empty) list of APT URLs, like this:

EXTRA_DEB_REPOS='deb http://ru.archive.ubuntu.com/ubuntu trusty main universe multiverse | deb http://ru.archive.ubuntu.com/ubuntu trusty-updates main universe multiverse'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/246888

[Aleksey Zvyagintsev (azvyagintsev)]

We not going to support fuel-bootstrap-image.sh script in fuel8
new ubuntu-bootstrap will be tested by different QA team, in sprint3.
what the point to support deprecated script, which not block currently no one ?

(My point if "support" of old script can block new implementation - lets drop it )

[Alexei Sheplyakov (asheplyakov)]

> We not going to support fuel-bootstrap-image.sh script in fuel8

This doesn't mean we should block people who are testing/using Ubuntu based bootstrap *now*.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/246888
Committed: https://git.openstack.org/cgit/openstack/fuel-menu/commit/?id=601536e7054a0f80a6ef78d4219b97f00fbf6e7e
Submitter: Jenkins
Branch: master

commit 601536e7054a0f80a6ef78d4219b97f00fbf6e7e
Author: Alexey Sheplyakov <email address hidden>
Date: Wed Nov 18 14:53:19 2015 +0300

    bootstrap: make a well formed fuel-bootstrap-image.conf

    EXTRA_DEB_REPOS is supposed to be a pipe (`|') separated list of APT URLs.

    Blueprint: master-on-centos7

    Compatible with CentOS6 master node

    Closes-Bug: #1516962

    Change-Id: I115218ae94da75eda382a36c80a2cbdea83accfb

[Aleksey Zvyagintsev (azvyagintsev)]

We no longer support old bootstrap builder, and have done switching to new one fuel-bootstrap tool.
Close bug due non-valid for current release\state.