auto-duck: option for fade-out time

[Daniel Schürmann]

I think what is missing from the auto-duck option is the fading time.

For example now, even in the smallest pauses the music rushes back up, whereas the functionality should be smoother. In other words, the ducking mechanism should "pause" a few milliseconds just in case the broadcaster is in the middle of his sentence.

Do you agree?

[Daniel Schürmann (daschuer)]

Yes.

The timing is set here:

https://github.com/mixxxdj/mixxx/blob/8f70bdcb277ed67e6bc53993c1bc97e8c160e141/src/engine/enginetalkoverducking.cpp#L25

I wonder how we make these setting accessible without clutter the GUI.

A third mode or a more intelligent algorithm ...

[Achilles (achatzianastassiou)]

I did download the nightly 12.1 alpha to check whether it is addressed there but it's not.

I'd be intrigued to have a go myself at changing the algorithm but my cpp skills (and my current pc environment) are close to 0.

For starters, maybe control it via an external xml that sets the fade in / fade out time in ms?

Something like

<AutoDuck>
     <FadeInTime>200<FadeInTime/>
     <FadeOutTime>400<FadeOutTime/>
<AutoDuck/>

Just writing out loud :)

[Daniel Schürmann (daschuer)]

Yes, something like this could be possible.
Once you are able to build Mixxx from source, and you have some remaining fun and spare time, you should be able to add such feature even without much c++ knowledge.

Accessing the config values will look like that:

m_pConfig->getValueString(ConfigKey(m_group, "duckAttackTime"), "0.1").toDouble()
m_pConfig->getValueString(ConfigKey(m_group, "duckDecayTime"), "1.0").toDouble()

On which OS are you?

[Achilles (achatzianastassiou)]

I'm in Windows 10. Should I try Eclipse or VS?
I've done .net in VS before.

[Daniel Schürmann (daschuer)]

VS is just fine. But since I am on Linux I cannot help much here.

Building on windows is hard, since you need to build the dependencies as well:
http://www.mixxx.org/wiki/doku.php/compiling_on_windows

In general, this should be helpful:
http://www.mixxx.org/wiki/doku.php/bugfix_workflow

If you get stucked, just ask, I hope a Windows guy or I can help.

[ronso0 (ronso0)]

I'd now start working on this and lp:1890633 "make microphone auto ducking attack faster" in one branch when there's a chance it gets into 2.3

Slow attack is a bug, so the fix should go to 2.3
While customizable fade-out is a feature.

what do you think

[Marzena Ziomalka (marzimala1)]

I was supposed to report a problem with microphone ducking,
but I found this thread.
I read it and did not understand if my problem was resolved?
The Duck Power knob on the Mixxx 2.3.1 works like this,
in the center, turns the music down halfway and turns it up quickly.
As I turn the knob to the left it turns the music down more and more
but it returns to full volume very slowly.
When it is fully to the left, the music is turned down completely,
but it returns to full volume very quickly.
I realized that some people were bothered when it returned to full volume too quickly,
however, now the intermediate knob setting is too long to return the volume to full.
The volume of the music could come back to full twice as fast as it does now and it would be smooth for the music and the long breath of spoken sentences.
When the 2.4 version is stable I will try different settings and come back to this error.
Best regards.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8298