Extra logging in SessionClient

Bug #1516549 reported by Tatiana Kholkina
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-muranoclient
Fix Released
Low
Tatiana Kholkina

Bug Description

When I run a command with non-existing id I get the following error:

$ murano environment-delete 123
404 Not Found
Environment with id 123 not found
    (HTTP 404)
Failed to delete '123'; environment not found
Unable to find and delete any of the specified environments.

I think we should remove logs before raising an exception https://github.com/openstack/python-muranoclient/blob/c60feee45cfa19522075cb0c824450eab514d23a/muranoclient/common/http.py#L315

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-muranoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/246439

Changed in python-muranoclient:
assignee: nobody → Tetiana Lashchova (tlashchova)
status: New → In Progress
Revision history for this message
Kirill Zaitsev (kzaitsev) wrote :

What if you try to delete 123 and 124. 124 does not exist, but 123 is. Would that still be clearly logged?

Changed in python-muranoclient:
status: In Progress → Opinion
importance: Undecided → Low
milestone: none → 0.8.0
Changed in python-muranoclient:
assignee: Tetiana Lashchova (tlashchova) → Victor Ryzhenkin (vryzhenkin)
status: Opinion → In Progress
Changed in python-muranoclient:
milestone: 0.8.0 → 0.8.1
Changed in python-muranoclient:
assignee: Victor Ryzhenkin (vryzhenkin) → Tetiana Lashchova (tlashchova)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-muranoclient (master)

Reviewed: https://review.openstack.org/246439
Committed: https://git.openstack.org/cgit/openstack/python-muranoclient/commit/?id=a643bb902d622b190dd1d57a710658dd02b9a43e
Submitter: Jenkins
Branch: master

commit a643bb902d622b190dd1d57a710658dd02b9a43e
Author: Tetiana Lashchova <email address hidden>
Date: Tue Nov 17 17:02:15 2015 +0200

    Change logging level in SessionClient

    Change-Id: I1052f4462fc4586c6d4c66cdd9aa2cea6cd65d13
    Closes-Bug: #1516549

Changed in python-muranoclient:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.