Floating IPs not translated in compute-->overview

Bug #1516162 reported by Floren
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Itxaka Serrano

Bug Description

In Compute overview page the text Floating IPs is not translated, in Access and security is translated correctly.

Steps to reproduced:

1. Change language to Spanish.
2. Go to the overview page (see screenshot).
3. Go to the Access & Security page, tab Floating IP (see screenshot). Here is translated correctly.

I test it in different language (French, Polish) with the same result.

Revision history for this message
Floren (florenllanos) wrote :
Revision history for this message
Floren (florenllanos) wrote :
Revision history for this message
guiyanxing (guiyanxing) wrote :

however,in Chinese language,floating ip is translated

Revision history for this message
Itxaka Serrano (itxaka) wrote :

Looks like "Floating IPs" is not being translated in here: https://github.com/openstack/horizon/blob/master/openstack_dashboard%2Fusage%2Fviews.py#L71

In fact, while the comment in there says that there are pairs of 3 items, the Floating IPs part has 4 instead.

Changed in horizon:
status: New → Confirmed
Itxaka Serrano (itxaka)
Changed in horizon:
assignee: nobody → Itxaka (itxakaserrano)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/248633

Changed in horizon:
status: Confirmed → In Progress
Doug Fish (drfish)
Changed in horizon:
importance: Undecided → Low
milestone: none → mitaka-1
Revision history for this message
Doug Fish (drfish) wrote :

FWIW, you can use the pseudo translation tool to provde that string is untranslatable in Horizon:
http://docs.openstack.org/developer/horizon/contributing.html#running-the-pseudo-translation-tool

I wouldn't mind seeing this proposed to stable/liberty. Although it's translation-related it isn't a new translation.

Changed in horizon:
importance: Low → Medium
tags: added: liberty-backport-potential
Revision history for this message
Doug Fish (drfish) wrote :

typo above - the pseudo translation tool can be used to _prove_ that a string cannot be translated.

Revision history for this message
Itxaka Serrano (itxaka) wrote :

Doug, Ill have a look at the pseudo, as Im pretty newbie at all the translation stuff.

I tested locally by generating the translations and changing between spanish and english and it did fix the translation.

Revision history for this message
Itxaka Serrano (itxaka) wrote :

Great pointer by Doug, the pseudo tool indeed shows that on the master branch the "Floating IPs" is indeed not translatable as show in the attachment. With this patch it show as translatable.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/248633
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=65f919e87f6b500568fb15870f7121f4da8a8b9c
Submitter: Jenkins
Branch: master

commit 65f919e87f6b500568fb15870f7121f4da8a8b9c
Author: Itxaka <email address hidden>
Date: Mon Nov 23 12:49:39 2015 +0100

    Translate Floating IPs on overview page

    Floating Ips was not being translated properly.

    Change-Id: I57128e0dba5e2524cc2a326abdfc983d46df4c69
    Closes-Bug: 1516162

Changed in horizon:
status: In Progress → Fix Committed
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0b1

This issue was fixed in the openstack/horizon 9.0.0.0b1 development milestone.

Changed in horizon:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.