When stack update is completed two events are logged in DB

Bug #1516090 reported by Rakesh H S
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Rakesh H S

Bug Description

| s4 | 8abc6a7a-1f09-474c-81e6-091509afcc2e | Stack UPDATE started | UPDATE_IN_PROGRESS | 2015-11-13T16:26:58 |
| test1 | 986b922b-9ecd-4879-8e01-c88785158449 | state changed | UPDATE_IN_PROGRESS | 2015-11-13T16:26:58 |
| test1 | 04bb3a39-fc13-40da-bdac-4bc41e1adf62 | state changed | UPDATE_COMPLETE | 2015-11-13T16:27:14 |
| s4 | e2068e2d-ccff-4147-842e-22f306221411 | Stack UPDATE completed successfully | UPDATE_COMPLETE | 2015-11-13T16:27:15 |
| s4 | adfdb118-1be2-43f8-a952-b0ac8e2110d2 | Stack UPDATE completed successfully | UPDATE_COMPLETE | 2015-11-13T16:27:16 |
+---------------+--------------------------------------+-------------------------------------+--------------------+---------------------+

Rakesh H S (rh-s)
Changed in heat:
assignee: nobody → Rakesh H S (rh-s)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/245810

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/245810
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=411360f7d130a7639bf01954eef71c8bf7d097fa
Submitter: Jenkins
Branch: master

commit 411360f7d130a7639bf01954eef71c8bf7d097fa
Author: Rakesh H S <email address hidden>
Date: Mon Nov 16 20:23:26 2015 +0530

    Fix to send only one notification when update completes

    Presently when an update is COMPLETE/FAILED, two events are reported.

    In update_task we are already sending notification when an update
    completes, however due to recent changes, notifications are also
    sent at the time of releasing stack lock.

    For update, we need not send notification when releasing lock.

    Change-Id: Idc81f87b143dc43fa5409798534646d8400559ff
    Closes-Bug: #1516090

Changed in heat:
status: In Progress → Fix Committed
Changed in heat:
milestone: none → mitaka-2
Rabi Mishra (rabi)
tags: added: liberty-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/255856

Revision history for this message
Sergey Kraynev (skraynev) wrote :
Changed in heat:
importance: Undecided → Medium
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/liberty)

Reviewed: https://review.openstack.org/255856
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=046ad02aba016aeec48f8506377d1e8d7322b9e1
Submitter: Jenkins
Branch: stable/liberty

commit 046ad02aba016aeec48f8506377d1e8d7322b9e1
Author: Rakesh H S <email address hidden>
Date: Mon Nov 16 20:23:26 2015 +0530

    Fix 'release' and 'state_set' for UPDATE action

    Remove redundant update and notification when releasing lock
    for UPDATE.

    Also make sure that 'state_set' calls _persist_state for UPDATE
    action as this is used in 'set_stack_and_resource_to_failed',
    to set the stack status to FAILED.

    Co-Authored-By: Rabi Mishra <email address hidden>
    Change-Id: I8a80e329604fdec6498acca0a71723100d412384
    Closes-Bug: #1523717
    Closes-Bug: #1516090
    (cherry picked from commit e1d0b6c04112eeba2bcc02ad3ba123539a81aff7
    and 411360f7d130a7639bf01954eef71c8bf7d097fa)

tags: added: in-stable-liberty
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/heat 6.0.0.0b2

This issue was fixed in the openstack/heat 6.0.0.0b2 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

This issue was fixed in the openstack/heat 6.0.0.0b2 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/heat 5.0.1

This issue was fixed in the openstack/heat 5.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.