[system_test]test deploy_node_multiple_interfaces failed with AssertionError: Condition was False

[Artem Hrechanychenko]

Scenario:
Deploy cluster with networks allocated on different interfaces

Scenario:
1. Create cluster in Ha mode with 1 controller
2. Add 1 node with controller role
3. Add 1 node with compute role
4. Add 1 node with cinder role
5. Split networks on existing physical interfaces
6. Deploy the cluster
7. Verify network configuration on each deployed node
8. Run network verification

https://product-ci.infra.mirantis.net/job/8.0.system_test.ubuntu.thread_1/41/console

FAIL: Deploy cluster with networks allocated on different interfaces
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/8.0.system_test.ubuntu.thread_1/fuelweb_test/helpers/decorators.py", line 80, in wrapper
    result = func(*args, **kwargs)
  File "/home/jenkins/workspace/8.0.system_test.ubuntu.thread_1/fuelweb_test/tests/test_ha_one_controller.py", line 655, in deploy_node_multiple_interfaces
    self.env.verify_network_configuration(node)
  File "/home/jenkins/workspace/8.0.system_test.ubuntu.thread_1/fuelweb_test/models/environment.py", line 493, in verify_network_configuration
    checkers.verify_network_configuration(node=node, remote=ssh)
  File "/home/jenkins/workspace/8.0.system_test.ubuntu.thread_1/fuelweb_test/helpers/checkers.py", line 111, in verify_network_configuration
    interface_description)
AssertionError: Condition was False.

[Artem Panchenko (apanchenko-8)]

Previously this test passed because check 'verify_network_configuration' was skipped (all networks where untagged) here:

https://github.com/openstack/fuel-qa/blob/df45a35b8bd0969d850f566c062dcec4c62d8978/fuelweb_test/helpers/checkers.py#L97-L98

Currently, by default we assign networks to different interfaces too, but VLAN tags remain for mgmt and storage networks. Looks like such behavior was introduced by https://github.com/openstack/fuel-qa/commit/7ce54c7d16d8bf1297ac08accf00d08823b8130f or recent changes to Nailgun. So 'verify_network_configuration' is not skipped now and it tries to check that IPs are assigned to interfaces correctly, but it does that in a wrong way.

Anyway, 'verify_network_configuration' method is deprecated a long time ago and should be refactored or removed (I prefer the second option, because we already have an advanced check for networks in tests for networking templates: https://github.com/openstack/fuel-qa/blob/df45a35b8bd0969d850f566c062dcec4c62d8978/fuelweb_test/tests/test_net_templates_base.py#L165 ).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/246309

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/246309
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=2bf6333eb04e65cbe5b5192eb6009b78dee1a7f5
Submitter: Jenkins
Branch: master

commit 2bf6333eb04e65cbe5b5192eb6009b78dee1a7f5
Author: asledzinskiy <email address hidden>
Date: Tue Nov 17 12:34:03 2015 +0200

    Remove verify_network_configuration method

    - Remove verify_network_configuration from tests due
    to having advanced check 'check_ipconfig_for_template'
    that is used in networking templates tests

    Change-Id: I441ed6b749c77ea81d07eaf192d34d00f7c78bf6
    Closes-Bug: #1516046

[Tatyanka (tatyana-leontovich)]

verified on latest run