fuel-library package doesn't need module specs

[Matthew Mosesohn]

Our fuel-library package we distribute is much larger than it needs to be because it contains spec test dirs for each module. These files are not required for deployment and we can strip them from the package.

Additionally, we should remove ".git" dirs

The current fuel-library package has the following content:
Normal puppet data (manifests/providers/functions/templates/files): 17m (2660 files)
git metadata: 29m (726 files)
Specs: 10m (1664 files)
Total: 56m (5050 files)

Handling these extra files adds baggage to deployment, considering scale impact of copying 5000+ files to each node, while we only need a small fraction of that to perform deployment.

[Maksim Malchuk (mmalchuk)]

My opinion - is not a good idea to remove git metadata from the puppet modules, because it very helpful to investigate and fix problems on the real environments. Sometimes it's simply to fix an issue be cherry-picking commit and redeploying the cluster again.

[Dmitry Bilunov (dbilunov)]

Would moving .git/ to another package (for example, named like "fuel-library-git") solve the problem without breaking your workflow?

[Maksim Malchuk (mmalchuk)]

It will be great to have two packages fuel-library and fuel-library-git in the same repo.

[Bartłomiej Piotrowski (bpiotrowski)]

-git package makes no sense. Just refer to Puppetfile (that should be shipped instead) for exact versions of modules.

[Maksim Malchuk (mmalchuk)]

It should, but not shipped. So this would be an option which is better than -git package.

[Thomas Goirand (thomas-goirand)]

Hi. Having .git files in a Debian repository is considered a bug in Debian. Please clean the orig.tar file correctly. By the way, this should be considered a bug in the build system.

As for the test for each thing, probably it is a good idea to leave them in, and then use autopkgtest to check if they work as expected. Just an idea though, I have a less strong opinion about them than I have with the .git.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/258171

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/258171
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=2512e40c8dd2895a051c112c4af825f9d2d49e9e
Submitter: Jenkins
Branch: master

commit 2512e40c8dd2895a051c112c4af825f9d2d49e9e
Author: Maksim Malchuk <email address hidden>
Date: Wed Dec 16 01:39:07 2015 +0300

    fuel-library package cleanup

    This commit removes not required for deployment 'spec' and '.git' dirs.
    Also it adds 'Puppetfile' file for some debugging purposes.

    Change-Id: I1b3af8fb61542fcd0ccf01c13dc345c1687c0635
    Closes-Bug: #1515988