splitpatch hangs on the first patch I tried it on

[Reinier Post]

My first attempt to use splitpatch caused it to hang on the patch I tried it on.
This is an up to date Ubuntu 14.04.3 LTS installation:
the splitpatch package version is

  0.0+20130626+gitbd6a83d-1

The current version of splitpatch found at

  https://github.com/benjsc/splitpatch/blob/46557eeebe743620dedb0a5fa3f2776da508dbee/splitpatch.rb

has no such problem, and its code is rather different.

The patch in question is here:

  https://jira.sakaiproject.org/secure/attachment/43241/SAM-1947_samigo-email-notifications_10.x.patch

Incidentally, patch refuses to apply that patch, saying it is malformed.
splitpatch still shouldn't hang on it.

[Reinier Post (reinpost)]

The culprit is the merge info in the patch. The latest splitpatch.rb saves it into the file ..patch (attached), while the existing splitpatch hangs on it.
The only other difference is that the current splitpatch.rb preserves the Index: lines in the resulting patches.

[Timo Jyrinki (timo-jyrinki)]

Removed the 'patch' tag as there's no patch fixing the actual bug, just a patch showing how the bug happens.

First we'd need a fixed version of splitpatch in a development Ubuntu version. http://launchpad.net/ubuntu/+source/splitpatch shows that there's a newer git snapshot in newer Ubuntus, although even that does not include the 2014 changes.

When/if the splitpatch would be fixed in a development Ubuntu version and a patch fixing this single issue found, the next step would be to update this bug according to https://wiki.ubuntu.com/StableReleaseUpdates to prepare backporting the fix to 14.04.

But first, it would be worth testing whether the 0.0+20131223+gitb13d810-1 version already fixes the issue, it's 6 months newer than the version in 14.04. The https://launchpad.net/ubuntu/+archive/primary/+files/splitpatch_0.0%2B20131223%2Bgitb13d810-1_all.deb package probably works just fine on 14.04 too since there are no dependency changes.

[Reinier Post (reinpost)]

The issue is indeed fixed in that version.
Also, the package installs without mentioning anything about dependencies.
This is Ubuntu 14.04.3 with the standard splitpath already installed.

So it looks like just offering that version as an upgrade would suffice to fix this bug.

Thanks a lot for the help.

[Timo Jyrinki (timo-jyrinki)]

The https://wiki.ubuntu.com/StableReleaseUpdates process does not generally allow providing completely new upstream versions as such, but I've now set up the bug to note that the bug is fixed in newer Ubuntus but would need a patch found for the 14.04.

[Logan Rosen (logan)]

Unsubscribing ~ubuntu-sponsors, as there's nothing actionable here.