Provisioning of nodes resets their pending_addition flag

[Julia Aranovich]

Can be reproduced on Fuel UI on custom #547 ISO.

Steps to reproduce:

1. create default env, add some node(s). The node(s) will have pending_addition = True attribute to determine they are not deployed.
2. start provisioning task for the environment and wait for its completion

Expected result: provisioned nodes can be deleted from the environment without deployment; user can configure disks/interfaces for provisioned node, change its roles

Actual result: provisioned node can not be deleted from the environment, just can be marked as pending deletion, that requires env deployment to delete the node; node disks/interfaces/roles can not be configured. This is because UI expects node has pending_addition attribute to be True to manage the staff described above. BUT after finished provisioning, env nodes have pending_addition = False

[Ihor Kalnytskyi (ikalnytskyi)]

I'm not sure about the following statement:

> user can configure disks/interfaces for provisioned node, change its roles

We do partitioning during provisioning, so any further changes to disks will not make any affect. And since partitioning depends on roles (each node may have different volumes), ability to change node roles for provisioned nodes will lead to unexpected results.

Though I agree that we should be able to remove provisioned nodes from the env.

[Julia Aranovich (jkirnosova)]

Igor, what about configuring of interfaces for provisioned nodes?

Also, we can update UI code to remove provisioned nodes from environment, but deleted provisioned nodes still has 'provisioned' status (not 'discover'). Is it Ok?

[Vitaly Kramskikh (vkramskikh)]

I think this bug is invalid - if we started provisioning, it's normally that this node is not pending_addition anymore - we started to handle it and it is already a part of the cluster. If we use pending_addition flag in UI for something, we may want to stop doing this. What do you think?

[Julia Aranovich (jkirnosova)]

According to the ticket https://bugs.launchpad.net/fuel/+bug/1518391 configuration of interfaces of a provisioned node is available.

And I agree, UI code should be changed to support deletion and interfaces configuration for provisioned node(s).