Fuel for OpenStack

Log steps function in fuel-qa should warn when there are errors in step order

Bug #1515610 reported by Alexandr Kostrikov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Low
Alexandr Kostrikov
Fuel for OpenStack 8.0

Bug Description

When I write tests, I do add steps.
But when I write tests, I often rearrange lines. So steps can be messed.

It happened there: https://review.openstack.org/#/c/234238/22/fuelweb_test/tests/tests_mirrors/test_use_mirror.py

I propose to add checks on steps.

Tags: area-qa
Alexandr Kostrikov (akostrikov-mirantis)
summary: - I made a mistake with log steps. This should not repeat again.
+ Log steps function in fuel-qa should warn when there are errors in step
+ order
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (master)

Fix proposed to branch: master
Review: https://review.openstack.org/244630

Changed in fuel:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (master)

Reviewed: https://review.openstack.org/244630
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=1dadcd0e5e83d1ca2d6512f94ca9ce7cc2e33dd7
Submitter: Jenkins
Branch: master

commit 1dadcd0e5e83d1ca2d6512f94ca9ce7cc2e33dd7
Author: Alexandr Kostrikov <email address hidden>
Date: Thu Nov 12 15:42:33 2015 +0300

    Add order check in fuel log_step.

    The ordering is meaningfull and can mislead in log investigation.
    Simple counter added.

    Change-Id: I3c2ace4bc0f6d0722a40a0a32086c83f96b7494d
    Closes-bug: #1515610

Changed in fuel:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.