Unnecessary "ugettext_lazy" procedure against name

Bug #1515100 reported by Shu Muto
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Shu Muto

Bug Description

Unnecessary "ugettext_lazy" procedure against database instance name and image name exist in detail view settings in views.py.

openstack_dashboard/contrib/trove/content/databases/views.py

class DetailView(tabs.TabView):
    tab_group_class = project_tabs.ImageDetailTabs
    template_name = 'horizon/common/_detail.html'
    page_title = _("{{ image.name }}")
                            ~~~~~~~~~~~~~~~~~

openstack_dashboard/dashboards/project/images/images/views.py

class DetailView(horizon_tabs.TabbedTableView):
    tab_group_class = tabs.InstanceDetailTabs
    template_name = 'horizon/common/_detail.html'
    page_title = _("{{ instance.name }}")
                            ~~~~~~~~~~~~~~~~~~~

Shu Muto (shu-mutou)
Changed in horizon:
status: New → In Progress
assignee: nobody → Shu Muto (shu-mutou)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/243950

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/243950
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=02fc82e2c5395c2e3933d8e639426b616f573b4b
Submitter: Jenkins
Branch: master

commit 02fc82e2c5395c2e3933d8e639426b616f573b4b
Author: shu-mutou <email address hidden>
Date: Wed Nov 11 13:29:52 2015 +0900

    Remove unnecessary ugettext_lazy

    This patch remove unnecessary ugettext_lazy procedure
    against database instance name and image name for
    page title in its detail view.

    Change-Id: I4f9a2b9ca7d43cf6fdf6ae02f50ad2f9c625d602
    Closes-Bug: #1515100

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
importance: Undecided → Low
milestone: none → mitaka-1
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0b1

This issue was fixed in the openstack/horizon 9.0.0.0b1 development milestone.

Changed in horizon:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.